When a bookmark is deleted, the corresponding offline copy isn't cleaned up |
|||
Issue descriptionVersion: 54.0.2804.1 OS: Android L After bookmarking a page, and offline copy is created. But if the bookmark is later deleted the offline copy remains taking up space and without letting users know it's available. If there's an offline copy associated with a bookmark we should probably just delete it. What steps will reproduce the problem? (1) Open Chrome 54.0.2804.1 (2) Navigate to a url (google.com/finance) (3) Bookmark the page (4) Verify an offline copy is created in chrome://offline-internals (5) Navigate to a the url in step 2, delete the bookmark (6) Go back to chrome://offline-internals What is the expected output? The offline copy will be deleted along with the bookmark. What do you see instead? The offline copy remains. Please use labels and text to provide additional information.
,
Jul 27 2016
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c02075fe34677d1d194b65e6b2536a3f2204640a commit c02075fe34677d1d194b65e6b2536a3f2204640a Author: romax <romax@chromium.org> Date: Fri Sep 02 21:17:40 2016 [Offline Pages] Delete associated page along with bookmark. When deleting bookmarks we should also delete the associated offline page cache. Doing this by adding an observer owned by BookmarkModel and get initialized as part of BookmarkModel. BUG= 630796 Review-Url: https://codereview.chromium.org/2185973003 Cr-Commit-Position: refs/heads/master@{#416343} [modify] https://crrev.com/c02075fe34677d1d194b65e6b2536a3f2204640a/chrome/browser/BUILD.gn [add] https://crrev.com/c02075fe34677d1d194b65e6b2536a3f2204640a/chrome/browser/android/offline_pages/offline_page_bookmark_observer.cc [add] https://crrev.com/c02075fe34677d1d194b65e6b2536a3f2204640a/chrome/browser/android/offline_pages/offline_page_bookmark_observer.h [modify] https://crrev.com/c02075fe34677d1d194b65e6b2536a3f2204640a/chrome/browser/bookmarks/chrome_bookmark_client.cc [modify] https://crrev.com/c02075fe34677d1d194b65e6b2536a3f2204640a/chrome/browser/bookmarks/chrome_bookmark_client.h [modify] https://crrev.com/c02075fe34677d1d194b65e6b2536a3f2204640a/components/offline_pages/BUILD.gn [modify] https://crrev.com/c02075fe34677d1d194b65e6b2536a3f2204640a/components/offline_pages/offline_page_model_impl.h
,
Sep 2 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dim...@chromium.org
, Jul 27 2016Owner: romax@chromium.org
Status: Assigned (was: Untriaged)