New issue
Advanced search Search tips

Issue 630793 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Fix ARC lowmemory management regression

Project Member Reported by cylee@chromium.org, Jul 22 2016

Issue description

ARC should use chrome side integrated lowmemorykiller memory management.
However recently Android lowmemorykiller was re-activated accidentally, and it tends to kill processes prematurely so cause poor user experience.
We should remove the lowmemorykiller module from kernel to solve it once and for it all.

Also we should merge the change back to previous milestones.
 

Comment 1 by dgreid@chromium.org, Jul 22 2016

Labels: Merge-Request-53
Change landed here: https://chromium-review.googlesource.com/360917 in ToT

Comment 2 by dimu@chromium.org, Jul 23 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Labels: M-53
Status: Assigned
Is this fixed now?
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 27 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by cylee@google.com, Jul 27 2016

I'm not chrome committer so don't have permission to mergeback the CL easily.
Could somebody help?

Comment 6 by uekawa@chromium.org, Jul 27 2016

strange, I can help if cherry-picking is all that's needed.

Comment 7 by cylee@google.com, Jul 27 2016

sorry my bad. Somehow thought it's a chromium CL...
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 27 2016

Labels: merge-merged-release-R53-8530.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bbbb41b67df6528ee60e0bb19675de1de433738c

commit bbbb41b67df6528ee60e0bb19675de1de433738c
Author: Dylan Reid <dgreid@chromium.org>
Date: Fri Jul 15 22:16:33 2016

cros-kernel2: Don't enable Android low memory killer

Low memory killing is handled by Chrome.

BUG= chromium:630793 
TEST=Android still boots, but get errors about oom_score_adj perms

Change-Id: I277250a440c44ea694291ff6545ea59283566ba5
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/360917
Commit-Ready: Dan Shi <dshi@google.com>
Reviewed-by: Cheng-Yu Lee <cylee@chromium.org>
Reviewed-by: Kevin Cernekee <cernekee@chromium.org>
(cherry picked from commit 5f9e7b6fca1137f78bc5910a49d94256b673e337)
Reviewed-on: https://chromium-review.googlesource.com/364000
Commit-Queue: Cheng-Yu Lee <cylee@chromium.org>
Tested-by: Cheng-Yu Lee <cylee@chromium.org>
Reviewed-by: Junichi Uekawa <uekawa@chromium.org>

[modify] https://crrev.com/bbbb41b67df6528ee60e0bb19675de1de433738c/eclass/cros-kernel2.eclass

Comment 9 by uekawa@chromium.org, Jul 28 2016

Status: Fixed (was: Assigned)
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 30 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Verified (was: Fixed)

Sign in to add a comment