New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630771 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 775603



Sign in to add a comment

Mac: background pinned tab title change should show an image, not animate

Project Member Reported by sky@chromium.org, Jul 22 2016

Issue description

This was done for all other platforms here: 473898.
 

Comment 1 by shrike@chromium.org, Jul 22 2016

Summary: Mac: background pinned tab title change should show an image, not animate (was: Mac: ackground pinned tab title change should show an image, not animate)

Comment 2 by shrike@chromium.org, Jul 22 2016

Cc: shrike@chromium.org
BTW, I don't see the badge on Windows (at least when I follow the steps in  Issue 131029 ).

Comment 3 by sky@chromium.org, Jul 22 2016

What version are you on? I'm not sure the fix has rolled out to stable.

Comment 4 by shrike@chromium.org, Jul 22 2016

Ah, that's probably it. This is 51.0.2704.103 Stable.

Comment 5 by tapted@chromium.org, Jul 25 2016

Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)
[mac triage] speculatively assigning to get it out of the triage queue, but shrike@ may have another owner/priority in mind.

(Of course, a mac_views_browser=1 build will pick up r401946 automatically, but that's not likely to appear on Mac stable until next year at the earliest)

Comment 6 by a...@chromium.org, Oct 17 2017

Blocking: 775603

Comment 7 by a...@chromium.org, Oct 20 2017

Cc: spqc...@chromium.org
Owner: a...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1e77b103a28eec4f63b52724d4bbba4a175e30c

commit b1e77b103a28eec4f63b52724d4bbba4a175e30c
Author: Avi Drissman <avi@chromium.org>
Date: Tue Oct 24 23:55:51 2017

Unify the "needs attention" indicator across desktop platforms.

This unifies the appearance as a blue dot and unifies function
as that dot for pinned tab title changes, tab-modal dialogs, and
soon-to-come background alert dialogs.

BUG= 775603 , 630771 , 473898 

Change-Id: I2e96db1c98455b8a9c0c896a95ad38482d79e3c2
Reviewed-on: https://chromium-review.googlesource.com/728719
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511310}
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_controller.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_controller.mm
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_view.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_view.mm
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/cocoa/tabs/tab_view_unittest.mm
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/tabs/tab_strip_model.cc
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/tabs/tab_strip_model.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/tabs/tab_strip_model_observer.cc
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/tabs/tab_strip_model_observer.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/b1e77b103a28eec4f63b52724d4bbba4a175e30c/chrome/browser/ui/views/tabs/tab_strip_unittest.cc

Comment 9 by a...@chromium.org, Oct 25 2017

Status: Fixed (was: Started)

Sign in to add a comment