New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630765 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 631228

Blocking:
issue 589726



Sign in to add a comment

benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:news:reddit is failing on Mac

Project Member Reported by nedngu...@google.com, Jul 22 2016

Issue description

Log:
[22/22] benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:news:reddit failed unexpectedly 186.6058s:
  [ RUN      ] browse:news:reddit
  Traceback (most recent call last):
    File "/b/swarm_slave/w/irZYG1Ic/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 85, in _RunStoryAndProcessErrorIfNeeded
      state.RunStory(results)
    File "/b/swarm_slave/w/irZYG1Ic/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 319, in RunStory
      self._current_page.Run(self)
    File "/b/swarm_slave/w/irZYG1Ic/third_party/catapult/telemetry/telemetry/page/__init__.py", line 99, in Run
      self.RunPageInteractions(action_runner)
    File "/b/swarm_slave/w/irZYG1Ic/tools/perf/page_sets/system_health/system_health_story.py", line 79, in RunPageInteractions
      self._DidLoadDocument(action_runner)
    File "/b/swarm_slave/w/irZYG1Ic/tools/perf/page_sets/system_health/browsing_stories.py", line 61, in _DidLoadDocument
      self._ReadNewsItem(action_runner)
    File "/b/swarm_slave/w/irZYG1Ic/tools/perf/page_sets/system_health/browsing_stories.py", line 66, in _ReadNewsItem
      action_runner.tab.WaitForDocumentReadyStateToBeComplete()
    File "/b/swarm_slave/w/irZYG1Ic/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 70, in WaitForDocumentReadyStateToBeComplete
      'document.readyState == "complete"', timeout)
    File "/b/swarm_slave/w/irZYG1Ic/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 136, in WaitForJavaScriptExpression
      e.message + '\n' + debug_message)
  TimeoutException: Timed out while waiting 90s for IsJavaScriptExpressionTrue.
  Console output:
  (log) http://www.12news.com/tegna-main-theme/js/main-header.js?minifierType=js&languageId=en_US&b=6110&t=1468376728000:9: timeBasedRefreshOnlyInViewport called with time of: 75000
  (log) http://www.12news.com/tegna-main-theme/js/main-header.js?minifierType=js&languageId=en_US&b=6110&t=1468376728000:9: initPosterScrollRefresh: poster_scroll found and timeBasedRefreshOnlyInViewport
  (log) http://www.12news.com/news/local/arizona/largest-us-measles-outbreak-in-arizona-after-people-refused-vaccinations/266726754:6: [object Object]
  (log) http://interactive.tegna-media.com/video/errorreporting/errorreporting.js:75: Successfully loaded error reporting assets.
  (log) http://interactive.tegna-media.com/video/jwloader/build/jwloader.js:1: Cannot load M3U8: Crossdomain access denied
  
  
  [  FAILED  ] browse:news:reddit (125193 ms)
  [  PASSED  ] 0 tests.
  [  FAILED  ] 1 test, listed below:
  [  FAILED  ]  browse:news:reddit


 
Cc: mpear...@chromium.org
Labels: OS-Mac
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8eaf29ebe657c4c3c7c07973f419c28ab6eea740

commit 8eaf29ebe657c4c3c7c07973f419c28ab6eea740
Author: nednguyen <nednguyen@google.com>
Date: Sat Jul 23 00:40:16 2016

[tools/perf] Disable system_health.memory_desktop.browse:news:reddit

BUG= 630765 

Review-Url: https://codereview.chromium.org/2169273005
Cr-Commit-Position: refs/heads/master@{#407320}

[modify] https://crrev.com/8eaf29ebe657c4c3c7c07973f419c28ab6eea740/tools/perf/benchmarks/system_health_smoke_test.py

Project Member

Comment 3 by sheriffbot@chromium.org, Jul 23 2016

Labels: Hotlist-Google
Cc: nedngu...@google.com
Owner: u...@chromium.org
Ulan: Could you please look into this?

Ned: Could you please provide a link to the bot that was failing?
Blocking: 589726
Cc: chrome-system-health-eng@google.com
Labels: Hotlist-SystemHealth
Status: Assigned (was: Untriaged)
Here are the last occurrences of the failure before the test was disabled:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/27486/steps/telemetry_perf_unittests%20on%20Mac-10.9/logs/stdio
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/25282/steps/telemetry_perf_unittests%20on%20Mac-10.9/logs/stdio

Comment 6 by u...@chromium.org, Jul 25 2016

Cc: nednguyen@chromium.org u...@chromium.org msramek@chromium.org mmentovai@chromium.org
 Issue 630686  has been merged into this issue.

Comment 7 by u...@chromium.org, Jul 25 2016

1) The test is failing on Mac 10.9 build bot.
2) The failure is timeout.
3) There is no Mac 10.9 perf bot.
4) Mac 10.10 build and perf bots are green on this benchmark:
- https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests?numbuilds=200
- https://build.chromium.org/p/chromium.perf/builders/Mac%2010.10%20Perf%20%283%29?numbuilds=200

So we are looking for difference between Mac 10.9 and Mac 10.10 that could explain the failure.

Unfortunately, I have only Mac 10.11 locally.

Ned, who is the owner of Mac 10.9. Can I get remote access?

Are tests run in parallel on the bot? Note that browsing stories use a lot of memory, so running them in parallel might result in swapping.

What about the discrepancy between Mac 10.9 build and perf bots? Running perf smoke tests but not running benchmarks seems like a bug to me. Should we either add 10.9 perf bot or remove the smoke test?
Cc: dtu@chromium.org sullivan@chromium.org
I agree that we should not run the smoke test on platforms that we don't run perf benchmark on.

+Annie, Dave: can I just remove telemetry_unittests & telemetry_perf_unittest from:
1) Mac 10.9 bots
2) All the (Dbg) bots?

Yes, but Dave can you file a separate ticket to upgrade the macbooks on the perf waterfall to 10.11?
Cl to remove telemetry_perf_unittest from Mac 10.9 bot & debug bots: https://codereview.chromium.org/2175293002/#

@ulan: after we can land that CL, I think all you need to do for this bug is to re-enable the smoke test. 
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c9960c8c03e272829395c4b3d0910bc8524a1ae

commit 4c9960c8c03e272829395c4b3d0910bc8524a1ae
Author: nednguyen <nednguyen@google.com>
Date: Mon Jul 25 19:37:45 2016

Remove telemetry_perf_unittest from Mac10.9 & dbg bots

We remove telemetry_perf_unittest suite from Mac10.9 & all dbg bots because we
don't run performance benchmark on those configuration (See attached bug for
more details)

BUG= 630765 

Review-Url: https://codereview.chromium.org/2175293002
Cr-Commit-Position: refs/heads/master@{#407545}

[modify] https://crrev.com/4c9960c8c03e272829395c4b3d0910bc8524a1ae/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/4c9960c8c03e272829395c4b3d0910bc8524a1ae/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/4c9960c8c03e272829395c4b3d0910bc8524a1ae/testing/buildbot/chromium.win.json

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caeaf0729434926b0140e2d0dfa3fac981ab742f

commit caeaf0729434926b0140e2d0dfa3fac981ab742f
Author: ulan <ulan@chromium.org>
Date: Mon Jul 25 21:52:00 2016

[tools/perf] Enable system_health.memory_desktop.browse:news:reddit and
system_health.memory_desktop.browse:news:nytimes.

Mac 10.9 does not run these tests after
https://codereview.chromium.org/2175293002

BUG= 630686 , 630765 

Review-Url: https://codereview.chromium.org/2178933002
Cr-Commit-Position: refs/heads/master@{#407600}

[modify] https://crrev.com/caeaf0729434926b0140e2d0dfa3fac981ab742f/tools/perf/benchmarks/system_health_smoke_test.py

Comment 13 by vabr@chromium.org, Jul 26 2016

I filed  bug 631456  for a similar issue on Win7 bots.

Comment 14 by dtu@chromium.org, Jul 27 2016

Blockedon: 631228
Can we mark this as fixed?

Comment 16 by u...@chromium.org, Aug 1 2016

Status: Fixed (was: Assigned)
Labels: hotlist-infra-opportunity

Sign in to add a comment