New issue
Advanced search Search tips

Issue 630746 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Need git mirror for https://github.com/WPO-Foundation/visualmetrics

Project Member Reported by prabhur@chromium.org, Jul 22 2016

Issue description

=== Create or edit a Git repo ===

googlesource host (e.g. chromium, chrome-internal): chromium
name of the repo: visualmetrics
is it a mirror, and of what: yes, https://github.com/WPO-Foundation/visualmetrics
permissions: same as public chromium repo

This is a tool that is required to measure speedindex score (how fast the viewport is filled up). This will go under third_party/visualmetrics/src (pending approval from chrome-eng-review).
 

Comment 1 by aga...@chromium.org, Jul 22 2016

This repo doesn't look to me like something that belongs in DEPS -- it doesn't look like it will be compiled in to chromium, and I'm not sure if or how this would be used in any automated testing.

Happy to create a mirror in general, but I'd like to have confirmation that one is actually necessary first.
Ping this bug once chrome-eng-review approves this code to be pulled into chromium gclient solution, I'll setup the mirror right away.
Hello vadimsh@, The CL https://codereview.chromium.org/2145673002/ has been approved by security@ and OSPTR.
Could you please create the mirror ? Thanks!


Owner: vadimsh@chromium.org
Status: Fixed (was: Untriaged)
Done: https://chromium.googlesource.com/external/github.com/WPO-Foundation/visualmetrics/
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/984ad5ceb395a0f89f1b77c18433bd5b1508bcc6

commit 984ad5ceb395a0f89f1b77c18433bd5b1508bcc6
Author: prabhur <prabhur@chromium.org>
Date: Tue Aug 02 20:08:21 2016

Adding visualmetrics code under third_party for speedindex calculations.
Visualmetrics python library is used to calculate speedindex score of a webpage navigation.

src/tools/licenses.py scan & src/tools/checklicenses/checklicenses.py  succeeded.

BUG= 630746 

Review-Url: https://codereview.chromium.org/2145673002
Cr-Commit-Position: refs/heads/master@{#409292}

[modify] https://crrev.com/984ad5ceb395a0f89f1b77c18433bd5b1508bcc6/.gitignore
[modify] https://crrev.com/984ad5ceb395a0f89f1b77c18433bd5b1508bcc6/DEPS
[add] https://crrev.com/984ad5ceb395a0f89f1b77c18433bd5b1508bcc6/third_party/visualmetrics/OWNERS
[add] https://crrev.com/984ad5ceb395a0f89f1b77c18433bd5b1508bcc6/third_party/visualmetrics/README.chromium

Sign in to add a comment