elf_imports_unittests fails due to a new dependency: RPCRT4.dll |
||
Issue descriptionClangToTLinux tester is reporting an issue with chrome_elf.dll dependencies: https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%20tester/builds/5594/steps/chrome_elf_unittests%20on%20Windows-7-SP1/logs/stdio [ RUN ] ELFImportsTest.ChromeElfSanityCheck ..\..\chrome_elf\elf_imports_unittest.cc(107): error: Value of: match Actual: false Expected: true Illegal import in chrome_elf.dll: RPCRT4.dll I would guess, this dependency is unexpected and unwelcome, but would like to hear confirmation from the code owners. This issue is currently blocking Clang toochain roll.
,
Jul 25 2016
Hi Ananta, can you please comment on whether this dependency legit or I should bisect LLVM and try to understand why was it added in the first place?
,
Jul 25 2016
Patch here. Adding rpcrt4 to the allowed list. https://codereview.chromium.org/2181793002/
,
Jul 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/101ccf53ead99297f70681fff4e7e469dcabc542 commit 101ccf53ead99297f70681fff4e7e469dcabc542 Author: ananta <ananta@chromium.org> Date: Wed Jul 27 00:30:57 2016 Add rpcrt4.dll to the list of allowed imports for chrome_elf.dll in the ELFImportsTest.ChromeElfSanityCheck test. Recent changes to chrome_elf to integrate with crashpad for crash reporting have brought in dependencies on base which pull in UuidCreate from rpcrt4. This code path is not exercised in chrome_elf which delay loads rpcrt4. I also verified that rpcrt4 does not internally pull in user32 Additionally I removed the list of dlls under COMPONENT_BUILD for this test as it does not run in this mode. BUG= 630744 Review-Url: https://codereview.chromium.org/2181793002 Cr-Commit-Position: refs/heads/master@{#407989} [modify] https://crrev.com/101ccf53ead99297f70681fff4e7e469dcabc542/chrome_elf/elf_imports_unittest.cc
,
Jul 27 2016
The bot cycled green: https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%20tester/builds/5661 Thank you for the fix! |
||
►
Sign in to add a comment |
||
Comment 1 by ananta@chromium.org
, Jul 22 2016Status: Assigned (was: Untriaged)