New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 630734 link

Starred by 4 users
Status: Fixed
Owner:
█ catmulli...@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
rdevlin....@chromium.org
lazyboy@chromium.org
█ asargent@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Extension warning bubbles show option to remove extension even if unable to

Project Member Reported by rdevlin....@chromium.org, Jul 22 2016 
What steps will reproduce the problem?
(1) Add a policy-controlled, force-installed extension that overrides proxy, ntp, search settings, home page, etc
(2) Observe warning bubble


What is the expected output?
The bubble should appear (fake policy extensions are an avenue for uws, so we want to be transparent), but should indicate that the extension is force-installed and cannot be removed.

What do you see instead?
The bubble offers to "restore settings", which would normally disable the extension.  Since the extension can't be disabled, this is meaningless.  
Assigning to catmullings@ who was looking for a good first UI bug.
Selection_339.png
73.9 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22bc237867193148a4a4e14ac925a41905fff817

commit 22bc237867193148a4a4e14ac925a41905fff817
Author: catmullings <catmullings@chromium.org>
Date: Wed Nov 02 19:59:35 2016

Improve settings override bubble to indicate policy installed extensions

Pertaining to settings override bubbles, remove button to
"Restore settings" and add a badge indicating that the extension was
installed by an administrator.

BUG= 630734 

Review-Url: https://codereview.chromium.org/2206693002
Cr-Commit-Position: refs/heads/master@{#429376}

[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/dev_mode_bubble_delegate.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/dev_mode_bubble_delegate.h
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/extension_message_bubble_controller.h
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/extension_service_sync_unittest.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/extension_service_test_with_install.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/extension_service_test_with_install.h
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/ntp_overridden_bubble_delegate.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/ntp_overridden_bubble_delegate.h
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/proxy_overridden_bubble_delegate.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/proxy_overridden_bubble_delegate.h
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/settings_api_bubble_delegate.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/settings_api_bubble_delegate.h
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/suspicious_extension_bubble_delegate.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/extensions/suspicious_extension_bubble_delegate.h
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac_unittest.mm
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/extensions/blocked_action_bubble_delegate.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/extensions/blocked_action_bubble_delegate.h
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/extensions/extension_message_bubble_bridge.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/extensions/extension_message_bubble_bridge.h
[add] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/extensions/extension_message_bubble_bridge_unittest.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc
[modify] https://crrev.com/22bc237867193148a4a4e14ac925a41905fff817/chrome/test/BUILD.gn

Comment 2 by catmulli...@chromium.org, Jan 11 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment