Provide finer control for accelerating component update checks (and avoid mistakes) |
||
Issue descriptionThe component updater supports a command line argument to facilitate DEBUGGING of component updates --component-updater=fast-update. When specified, the flag affects the timings of the component update checks, such as the time to initial check, and the time interval between successive checks. These flags should not be used in production code. Nevertheless, they were. There have been instances in the past where DDOS conditions occurred when the embedders of the component updater had used the fast-update flag to speedup the install of a specific component without realizing that the flag results in increasing the number of update check QPS by three orders of magnitude. The proposal is to implement the following testing flags: * fast-update: the existing fast-update flag only accelerates the initial check. It will not change the frequency of update checks. * fast-update-next-check-delay: how long to wait until the next update check, in seconds. * fast-update-ondemand-delay: the cooldown until the next ondemand delay can be handled, in seconds.
,
Jul 22 2016
Another option could be to support only one flag and nerf its effect: * fast-update: the existing fast-update flag only accelerates the initial check. It will not change the frequency of update checks. This way, we eliminate the possibility of a DDOS entirely, in theory.
,
Jul 22 2016
I think the proposal in comment #2 avoids the potential of embedders shortening the delays (perhaps creating worse potential for DDOS).
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dd028dc9d9b9b20a27bddd695d6a57ca0c0dae9 commit 3dd028dc9d9b9b20a27bddd695d6a57ca0c0dae9 Author: sorin <sorin@chromium.org> Date: Tue Jul 26 00:06:34 2016 Test current behavior of -component-updater=fast-update in ConfiguratorImpl. This is a change in preparation for modyfing the timings of the component updater. R=waffles BUG= 630732 Review-Url: https://codereview.chromium.org/2169323003 Cr-Commit-Position: refs/heads/master@{#407642} [modify] https://crrev.com/3dd028dc9d9b9b20a27bddd695d6a57ca0c0dae9/chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc [modify] https://crrev.com/3dd028dc9d9b9b20a27bddd695d6a57ca0c0dae9/components/component_updater/BUILD.gn [modify] https://crrev.com/3dd028dc9d9b9b20a27bddd695d6a57ca0c0dae9/components/component_updater/configurator_impl.cc [add] https://crrev.com/3dd028dc9d9b9b20a27bddd695d6a57ca0c0dae9/components/component_updater/configurator_impl_unittest.cc [modify] https://crrev.com/3dd028dc9d9b9b20a27bddd695d6a57ca0c0dae9/components/components_tests.gyp
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/718f246d8c9c0fb85a1b1f1f7b2efcfcebc060cf commit 718f246d8c9c0fb85a1b1f1f7b2efcfcebc060cf Author: sorin <sorin@chromium.org> Date: Tue Jul 26 01:02:40 2016 fast-update flag only accelerates the first component update check. BUG= 630732 Review-Url: https://codereview.chromium.org/2179593003 Cr-Commit-Position: refs/heads/master@{#407664} [modify] https://crrev.com/718f246d8c9c0fb85a1b1f1f7b2efcfcebc060cf/chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc [modify] https://crrev.com/718f246d8c9c0fb85a1b1f1f7b2efcfcebc060cf/components/component_updater/configurator_impl.cc [modify] https://crrev.com/718f246d8c9c0fb85a1b1f1f7b2efcfcebc060cf/components/component_updater/configurator_impl_unittest.cc
,
Jul 26 2016
For now, fast-update flag only accelerates the first component update check. Adding other flags complicates usability and increases the likelihood of making errors. Please reopen if more sophisticated behavior is needed for test scenarios. |
||
►
Sign in to add a comment |
||
Comment 1 by pbomm...@chromium.org
, Jul 22 2016