New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630725 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Merge Skia infra build/test asset changes into m53 branch to prevent bots from breaking

Project Member Reported by bore...@google.com, Jul 22 2016

Issue description

Merge Skia infra build/test asset changes into m53 branch to prevent bots from breaking

These changes will prevent the Skia bots from breaking on the next cherry-pick to the m53 branch: https://codereview.chromium.org/2175743004/
 

Comment 1 by gov...@chromium.org, Jul 22 2016

Cc: -hcm@chromium.org gov...@chromium.org
Owner: hcm@chromium.org
hcm@, is it safe to take this change in for M53 as I'm not too familiar with Skia changes?
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 23 2016

Labels: Hotlist-Google

Comment 3 by dimu@chromium.org, Jul 23 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)

Comment 4 by bore...@google.com, Jul 25 2016

These are Skia-infrastructure-only changes which should be completely safe.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25 2016

Labels: merge-merged-m53
The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/eee1b9f17e74cee4f768cba2fec368bd410064d9

commit eee1b9f17e74cee4f768cba2fec368bd410064d9
Author: borenet <borenet@chromium.org>
Date: Mon Jul 25 11:34:07 2016

Cherry-pick infra assets changes to chrome/m53 to prevent bots breaking

-----

Change SKPs to new asset management format

BUG= skia:5427 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2169653003
DOCS_PREVIEW= https://skia.org/?cl=2169653003

Review-Url: https://codereview.chromium.org/2169653003

-----

Add "skp" asset

Don't get rid of SKP_VERSION and associated stuff just yet.

BUG= skia:5427 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167763002
DOCS_PREVIEW= https://skia.org/?cl=2167763002

Review-Url: https://codereview.chromium.org/2167763002

-----

Add vulkan sdk to CIPD

BUG= skia:5427 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164953002

Review-Url: https://codereview.chromium.org/2164953002

-----

BUG= 630725 
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2175743004

[delete] https://crrev.com/51d62dbed83e0be2922662570eb6ca34c8170416/SKP_VERSION
[modify] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/bin/fetch-skps
[add] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/infra/bots/assets/skp/VERSION
[add] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/infra/bots/assets/skp/common.py
[add] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/infra/bots/assets/skp/create.py
[add] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/infra/bots/assets/skp/create_and_upload.py
[add] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/infra/bots/assets/skp/download.py
[add] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/infra/bots/assets/skp/upload.py
[add] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/infra/bots/assets/win_vulkan_sdk/README.md
[add] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/infra/bots/assets/win_vulkan_sdk/VERSION
[add] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/infra/bots/assets/win_vulkan_sdk/common.py
[add] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/infra/bots/assets/win_vulkan_sdk/download.py
[add] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/infra/bots/assets/win_vulkan_sdk/upload.py
[delete] https://crrev.com/51d62dbed83e0be2922662570eb6ca34c8170416/infra/bots/common.py
[delete] https://crrev.com/51d62dbed83e0be2922662570eb6ca34c8170416/infra/bots/download_skps.py
[modify] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/infra/bots/perf_skia.isolate
[delete] https://crrev.com/51d62dbed83e0be2922662570eb6ca34c8170416/infra/bots/skps.isolate
[modify] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/infra/bots/test_skia.isolate
[modify] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/site/dev/testing/skps.md
[delete] https://crrev.com/51d62dbed83e0be2922662570eb6ca34c8170416/tools/skp/recreate_skps.py
[modify] https://crrev.com/eee1b9f17e74cee4f768cba2fec368bd410064d9/tools/skp/webpages_playback.py

Comment 6 by bore...@google.com, Jul 25 2016

Labels: -Merge-Approved-53 Merge-Merged

Comment 7 by hcm@chromium.org, Aug 18 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment