New issue
Advanced search Search tips

Issue 630719 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Fix legacy strings in OptIn UI

Project Member Reported by khmel@chromium.org, Jul 22 2016

Issue description

Inner bug: b/30288220

We have to sync current strings with latest requirements.

Changes are:

For UMA:
your administrator -> the owner
will send -> currently sends

For locations remove "You can change this in Android Settings at any time"

CL: https://codereview.chromium.org/2169173002
MOCK: https://docs.google.com/presentation/d/1A0PFCDsO4A37fatqmFCtJjkBJomZEbkbhJMTbNRt3XU/edit#slide=id.p


 

Comment 1 by khmel@chromium.org, Jul 22 2016

Labels: M-53

Comment 2 by khmel@chromium.org, Jul 22 2016

Labels: Merge-Request-53
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/257528980238608146ee8fdb694112cf971ab293

commit 257528980238608146ee8fdb694112cf971ab293
Author: khmel <khmel@chromium.org>
Date: Fri Jul 22 20:24:33 2016

arc: Fix legacy strings for OptIn flow.

BUG= 630719 
TEST=N/A

Review-Url: https://codereview.chromium.org/2169173002
Cr-Commit-Position: refs/heads/master@{#407247}

[modify] https://crrev.com/257528980238608146ee8fdb694112cf971ab293/chrome/app/chromeos_strings.grdp

Comment 4 by khmel@chromium.org, Jul 22 2016

Status: Fixed (was: Started)

Comment 5 by dimu@chromium.org, Jul 23 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 27 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 27 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b367108fb464e1c03bca6ccc106a61169c0e325

commit 4b367108fb464e1c03bca6ccc106a61169c0e325
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Wed Jul 27 15:58:21 2016

arc: Fix legacy strings for OptIn flow.

BUG= 630719 
TEST=N/A

Review-Url: https://codereview.chromium.org/2169173002
Cr-Commit-Position: refs/heads/master@{#407247}
(cherry picked from commit 257528980238608146ee8fdb694112cf971ab293)

R=lhchavez@chromium.org

Review URL: https://codereview.chromium.org/2176343003 .

Cr-Commit-Position: refs/branch-heads/2785@{#370}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/4b367108fb464e1c03bca6ccc106a61169c0e325/chrome/app/chromeos_strings.grdp

Status: Verified (was: Fixed)

Sign in to add a comment