Missing Coverage on CQ for Image Decoding |
||||
Issue descriptionAs sheriff, I recently had to revert a change related to image decoding. For details see https://codereview.chromium.org/2173603003/ The original author wondered how this change passed the CQ. Can someone on blink infra look into why this is only tested on the tree, not the CQ, and hopefully fix it?
,
Aug 4 2016
Someone from layout test Infra should probably take the first pass on this.
,
Aug 4 2016
The only bots on the CQ that run layout tests currently are: linux_chromium_rel_ng (Linux Precise release) mac_chromium_rel_ng (Mac 10.9 release) win_chromium_rel_ng (Win 7 release) The advantage of using release builds is that all of the layout test baselines are generated using release builds, and there are some mismatches between the results with release and debug builds. In theory, we could also have try jobs that run layout tests with debug builds (and with more platforms and OS versions) since for cases where debug builds have results that don't match the baselines, this should be noted in LayoutTests/TestExpectations. As far as I know, the main reasons why we wouldn't have try bots on the CQ that run layout tests on all platforms with debug builds is resource consumption and cost -- layout tests currently take a long time to run so we'd need more computing time -- which may be more acceptable if layout tests were all run on swarming ( bug 524758 ). Dirk, does that sound correct?
,
Aug 4 2016
We don't run any tests in debug configurations in the commit queue (it's not just that we don't run layout tests). And, yes, the reasons are that debug is too slow, would take too many machines, and the overhead of managing all the different configurations for both infra and users would be too high. Most test steps run release with DCHECKs enabled, which gives us pretty good debug coverage, but we can't do that for the layout tests because we've sometimes seen that that will produce slight differences in the PNGs, which causes trybots to fail on tests that will pass on the waterfall. These sorts of failures are pretty rare, so this is viewed as the right tradeoff. mpearson@, does that all make sense? If so, I'd WontFix this.
,
Aug 4 2016
This makes sense. You can WontFix this. But if as I/we look down the list I made recently of things that passed the CQ and failed on the bots and we see many similar situations, we'll need to revisit it.
,
Aug 5 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by benhenry@chromium.org
, Aug 4 2016