git cl for Gerrit produces garbled unreadable warnings with a prompt on Mac |
||||||||||||||
Issue descriptionTrying to land https://chromium-review.googlesource.com/c/362660/ from the command line: -- % git cl land Using 50% similarity for rename/copy detection. Override with --similarity. r you. Are you sure you wish to bypass it?e, which can test and land changes fo ort.s Enter to continue, Ctrl+C to ab -- with the cursor flashing at me on the “s” after “ort.” Yeah, so that’s something about the commit queue, I guess? Which we don’t have for Breakpad. 1. Fix the message so that it’s readable. 2. Don’t offer it in projects with no commit-queue Perhaps this is an artifact of https://chromium-review.googlesource.com/c/362370/ not actually having landed yet? I used “git cl upload --gerrit” to create this code review on Gerrit.
,
Jul 22 2016
,
Jul 25 2016
Thanks for the report! 1. I have no idea what's wrong with the message. It looks rather good in Python code: https://cs.chromium.org/chromium/tools/depot_tools/git_cl.py?type=cs&q=%22which+can+test+and+land+changes+for+you.%22&sq=package:chromium&l=2274 So, it must be some weird interaction between python, git_cl and windows. 2. Sadly, your project "seems" to have Commit Queue, at least Gerrit UI shows it: https://screenshot.googleplex.com/A2DshNYevAY. I have no idea why.
,
Jul 25 2016
Ah, I know why: https://chromium.googlesource.com/breakpad/+/9bac42409cdd77342b62a4f51f849b155e57fd27/project.config#16 fix: https://chromium.googlesource.com/breakpad/+/f6c77cb7a06f2c2657074e3848f61e6d2fd47d85/project.config#16 agable@ wdyt about removing CQ label config from All-Projects as well? https://chromium.googlesource.com/All-Projects/+/refs/meta/config/project.config#54
,
Jul 25 2016
,
Jul 25 2016
And now there is no more gray "Commit-Queue" label on your review. Mind trying git cl land again?
,
Jul 25 2016
git cl land works now. Thanks! https://chromium.googlesource.com/breakpad/breakpad/+/f5638b8c2e309dc292571d8ee2035b3393ec5f5c I’m still concerned about the message that didn’t print correctly. This was Mac, not Windows, and I’m using Terminal.app. There’s definitely something weird about Python raw_input and prompt strings with newlines or prompt strings wider than the terminal.
,
Jul 25 2016
I ran unit tests of git_cl on Mac a few times (no CI for it, yet?) and they pass, though stdio streams are mocked. So, I also think the bug is somewhere in interaction of raw_input and terminal app. This is not super high priority on my list tbh, but I'm likely biased as I don't use MacOS at all. If enough people star this issue (10+?), I'll have a look (but I prefer daily MacOS user does it instead :) ).
,
Jul 25 2016
tandrii@: I'm already working on removing the CQ label config from All-Projects. First part here: https://chromium-review.googlesource.com/#/c/362700/ But that's a discussion for a different bug.
,
Sep 27 2016
If this occurs again, please re-open the bug. We haven‘t seen this from any other users.
,
Nov 1 2016
Still happening. See https://bugs.chromium.org/p/gerrit/issues/detail?id=4847.
,
Nov 1 2016
,
Jan 12 2017
,
Jan 3 2018
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
,
Jan 4 2018
Removing myself from all Pri-2/3 Gerrit issues and setting them to Available, to more accurately reflect the fact that there are a bunch of Pri-1 bugs open, and I'm splitting my time between codereview and codesearch.
,
Jan 4
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 4
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by andyb...@chromium.org
, Jul 22 2016Labels: -Pri-3 Pri-2
Owner: tandrii@chromium.org