So... I'd like to roll gtest because I'm about to make a change upstream that I want in Chromium... (ref. https://codereview.chromium.org/2162053006/)
But they both haven't been rolled since a year ago (July 28th 2015 is the last commit).
Two major things to consider:
1) As of https://github.com/google/googletest/commit/1f87a0970dc0880c954ea4066fd7b72fad6fb089 the entire repo moved one level down into googletest/
i.e. "testing/gtest/include/gtest/gtest.h" would now be "testing/gtest/googletest/include/gtest/gtest.h"
2) gmock also moved to googlemock/ in the root of this repo (they've coalesced in the same repo as explained here https://github.com/google/googletest)
(the current repo is still on SVN and is either a mirror or is dead -- haven't checked)
Proposal:
A) Our existing gtest.gyp and gmock.gyp already specify an include_dirs to "include/gtest" and "include/gmock" so that it's already okay in Chromium to do #include "gtest/gtest.h" instead of "testing/gtest/include/gtest/gtest.h"
=> Add a presubmit against the full path and force people to use #include "gtest/gtest.h" and "gmock/gmock.h"
B) Mass rename includes in existing codebase.
C) Move DEPS on gtest and update gtest include_dirs to "googletest/include/gtest" (hopefully everything else still works..!)
D) Delete gmock and add "googlemock/include/gmock" to gtest.gyp's include_dirs (effectively "moving" DEPS on gmock).
I'll go ahead and prepare a CL for the PRESUBMIT in (A) -- the other option is to have (B) instead update all the full paths to the new full paths but that'll be harder because (a) we'll need to change over 6500 files in lock step with rolling DEPS :-O and (b) it means we could have to do this over again if the full path somehow changed again...!
Comment 1 by gab@chromium.org
, Jul 22 2016