Issue 630696 link

Starred by 2 users

Issue metadata

Status:	Archived
Owner:	█ reve...@chromium.org Last visit > 30 days ago
Closed:	Jul 2016
Cc:	osh...@chromium.org hidehiko@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
M-53 Hotlist-Merge-Approved merge-merged-2785 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Exosphere ShellSurface forgets maximized state when becoming fullscreen

Project Member Reported by reve...@chromium.org, Jul 22 2016

Issue description

1. Run weston-terminal
2. Maximize the terminal
3. Press F4 to enter fullscreen mode
4. Press F4 to exit fullscreen mode

Terminal is restored to non-maximized mode when it's expected that exiting fullscreen mode should result in it being maximized.

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25f638ab8c4adbf3470b2e0e07183919f60bc3f9

commit 25f638ab8c4adbf3470b2e0e07183919f60bc3f9
Author: reveman <reveman@chromium.org>
Date: Fri Jul 22 20:27:18 2016

exo: Implement custom fullscreening for ShellSurfaces.

This allows us to restore to maximized mode when fullscreen
is toggled by the user pressing F4.

BUG= 630696 ,b/29817350
TEST=exo_unittests --gtest_filter=ShellSurfaceTest.ToggleFullscreen

Review-Url: https://codereview.chromium.org/2177623002
Cr-Commit-Position: refs/heads/master@{#407248}

[modify] https://crrev.com/25f638ab8c4adbf3470b2e0e07183919f60bc3f9/components/exo/shell_surface.cc
[modify] https://crrev.com/25f638ab8c4adbf3470b2e0e07183919f60bc3f9/components/exo/shell_surface_unittest.cc

Comment 2 by reve...@chromium.org, Jul 22 2016

Labels: Merge-Request-53
Status: Fixed (was: Started)

Comment 3 by dimu@chromium.org, Jul 23 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved

Your change meets the bar and is auto-approved for M53 (branch: 2785)

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 2016

Labels: -merge-approved-53 merge-merged-2785

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f44deef2faa1b672f672a504e470d9d5eaac1112

commit f44deef2faa1b672f672a504e470d9d5eaac1112
Author: David Reveman <reveman@chromium.org>
Date: Sun Jul 24 02:04:38 2016

exo: Implement custom fullscreening for ShellSurfaces.

This allows us to restore to maximized mode when fullscreen
is toggled by the user pressing F4.

BUG= 630696 ,b/29817350
TEST=exo_unittests --gtest_filter=ShellSurfaceTest.ToggleFullscreen

Review-Url: https://codereview.chromium.org/2177623002
Cr-Commit-Position: refs/heads/master@{#407248}
(cherry picked from commit 25f638ab8c4adbf3470b2e0e07183919f60bc3f9)

Review URL: https://codereview.chromium.org/2174193002 .

Cr-Commit-Position: refs/branch-heads/2785@{#320}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/f44deef2faa1b672f672a504e470d9d5eaac1112/components/exo/shell_surface.cc
[modify] https://crrev.com/f44deef2faa1b672f672a504e470d9d5eaac1112/components/exo/shell_surface_unittest.cc