Remove MediaInternalsVideoCaptureDeviceTest.AllCaptureApiTypesHaveProperStringRepresentation |
|||||||
Issue descriptionThe test MediaInternalsVideoCaptureDeviceTest.AllCaptureApiTypesHaveProperStringRepresentation [1] appears to be a duplicate implementation of the behavior being tested. As such the test creates the burden of maintaining it without adding any value. We should remove it. [1] https://cs.chromium.org/chromium/src/content/browser/media/media_internals_unittest.cc?q=media_internals_unittest.cc&dr&l=117
,
Jul 27 2016
,
Aug 15 2016
Is this unit test owned by Media>Video team?
,
Aug 17 2016
,
Aug 18 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 31 2017
this bug has been stale for > 1 year. close it with label StaleClosed.
,
May 1 2018
,
May 1 2018
This popped up again as part of https://chromium-review.googlesource.com/c/chromium/src/+/1038644 so I am going to fix it now.
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81bfea37e0fceec0d59bda99c22ef9acf4143b6a commit 81bfea37e0fceec0d59bda99c22ef9acf4143b6a Author: Christian Fremerey <chfremer@chromium.org> Date: Wed May 02 15:03:39 2018 [Video Capture] Remove test AllCaptureApiTypesHaveProperStringRepresentation Besides the test being a redundant implementation of what is tested, we can rely on compile-time checks that all cases of the enum class are handled, so this test is not needed. Bug: 630694 Change-Id: I618a50692b1fc7a643a7863b477a54c6fee9e93f Reviewed-on: https://chromium-review.googlesource.com/1038743 Reviewed-by: Emircan Uysaler <emircan@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#555388} [modify] https://crrev.com/81bfea37e0fceec0d59bda99c22ef9acf4143b6a/content/browser/media/media_internals_unittest.cc [modify] https://crrev.com/81bfea37e0fceec0d59bda99c22ef9acf4143b6a/media/capture/video/video_capture_device_descriptor.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by chfremer@chromium.org
, Jul 27 2016