New issue
Advanced search Search tips

Issue 630687 link

Starred by 2 users
Status: WontFix
Owner:
xingliu@chromium.org
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clean blimp android resources

Project Member Reported by xingliu@chromium.org, Jul 22 2016 

Currently we reuse blimp java resources file inside blimp for clank integration. The resources are shared by v0.5 standalone app and v0.6 integration.

This includes xml files, grd files. 


At some point in the future, we may need to move these resources to Chrome or separate these resources with v0.5 standalone app.

Comment 1 by xingliu@chromium.org, Jul 22 2016

Owner: xingliu@chromium.org

Comment 2 by xingliu@chromium.org, Sep 9 2016 

Also we may consider to have a grd file for native code to pull string directly in c++ code. 
The contents of grd file for android and native data package are different.

Target will be grit("blimp_strings"), add an entry in src/tools/gritsettings/resource_ids.

Comment 3 by xingliu@chromium.org, Oct 14 2016 

The resource setup is ongoing, but now we are using the enable_blimp_client flag to hide part of the code from normal chrome build, this also apply to string resources.

At some point when we remove the build flag, we can also clean up and simplify the string resources build flow.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12f1340436b88c4d91355935bea8bdbfb28a58cf

commit 12f1340436b88c4d91355935bea8bdbfb28a58cf
Author: xingliu <xingliu@chromium.org>
Date: Tue Oct 18 17:26:25 2016

Added blimp support strings.

Previously we use 0.5 strings in //blimp/client/app, which are also java
strings generated from a grd file.

This CL port some of the strings into //blimp/client/support/resources.
The embedder may depend on this to access blimp external strings.

The grd file for support strings will only generate strings used in
native code.

There will be another grd file for blimp internal only strings.

BUG= 630687 

Review-Url: https://codereview.chromium.org/2406203003
Cr-Commit-Position: refs/heads/master@{#426001}

[modify] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/DEPS
[modify] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/BUILD.gn
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/BUILD.gn
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/blimp_strings.cc
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/blimp_strings.grd
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/blimp_strings.h
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_am.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_ar.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_bg.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_ca.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_cs.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_da.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_de.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_el.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_en-GB.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_es-419.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_es.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_fa.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_fi.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_fil.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_fr.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_hi.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_hr.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_hu.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_id.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_it.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_iw.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_ja.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_ko.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_lt.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_lv.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_nl.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_no.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_pl.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_pt-BR.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_pt-PT.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_ro.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_ru.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_sk.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_sl.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_sr.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_sv.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_sw.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_th.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_tr.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_uk.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_vi.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_zh-CN.xtb
[add] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/blimp/client/support/resources/translations/blimp_strings_zh-TW.xtb
[modify] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/chrome/browser/BUILD.gn
[modify] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/chrome/browser/android/DEPS
[modify] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc
[modify] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/chrome/chrome_repack_locales.gni
[modify] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/tools/gritsettings/resource_ids
[modify] https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf/tools/gritsettings/translation_expectations.pyl
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d4d7a54a39b017222ce964baaf8431f4453a957

commit 7d4d7a54a39b017222ce964baaf8431f4453a957
Author: xingliu <xingliu@chromium.org>
Date: Fri Nov 11 03:42:57 2016

Setup Blimp internal string resources.

Previously the 0.6 Chrome/Blimp integrated build still use strings in
//blimp/client/app, which also only generates android strings files.

This CL:
1. Setup strings resources in //blimp/client/core, all core code won't
use app resources anymore.

2. Internal core strings are protected behind the build flag
|enable_blimp_client|, so normal Chrome build won't contain Blimp
internal strings. Also the build flag is only used in
//blimp/client/core build files.

3. The Blimp linux shell only loads the English string pak file. Unit
tests and 0.5 app currently don't depends on the new core strings.

Clean resources bug.
BUG= 630687 

Decouple app and core code bug.
BUG= 651964 

Review-Url: https://codereview.chromium.org/2431653004
Cr-Commit-Position: refs/heads/master@{#431484}

[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/DEPS
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/app/BUILD.gn
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/app/blimp_startup.cc
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/app/blimp_startup.h
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/app/linux/blimp_client_context_delegate_linux.cc
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/app/linux/blimp_main.cc
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/BUILD.gn
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/contents/BUILD.gn
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/input/ImeHelperDialog.java
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/input/WebInputConfirmationPanel.java
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/BUILD.gn
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/drawable/dotted_line.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/layout/text_input_popup.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/layout/web_input_bottom_panel.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/values/arrays.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/values/colors.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/values/dimens.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/xml/blimp_preferences.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/blimp_strings.cc
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/blimp_strings.grd
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/dummy_blimp_strings.cc
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/dummy_blimp_strings.grd
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_am.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_ar.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_bg.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_ca.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_cs.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_da.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_de.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_el.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_en-GB.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_es-419.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_es.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_fa.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_fi.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_fil.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_fr.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_hi.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_hr.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_hu.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_id.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_it.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_iw.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_ja.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_ko.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_lt.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_lv.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_nl.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_no.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_pl.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_pt-BR.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_pt-PT.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_ro.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_ru.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_sk.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_sl.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_sr.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_sv.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_sw.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_th.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_tr.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_uk.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_vi.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_zh-CN.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_zh-TW.xtb
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/settings/BUILD.gn
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/public/BUILD.gn
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/public/blimp_client_context_delegate.h
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/public/resources/BUILD.gn
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/public/resources/blimp_strings.h
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/build/android/lint/suppressions.xml
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/chrome/chrome_repack_locales.gni
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/tools/gritsettings/resource_ids
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/tools/gritsettings/translation_expectations.pyl

Comment 6 by xingliu@chromium.org, Nov 30 2016

Status: WontFix (was: Untriaged)
►

Sign in to add a comment