New issue
Advanced search Search tips

Issue 630683 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Aug 13
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 612331



Sign in to add a comment

Figure out what previous_accelerator is needed for in ash

Project Member Reported by sky@chromium.org, Jul 22 2016 
The accelerator code uses the previous accelerator (keyevent) to make some decisions. In the mash world ash will only see accelerators it registers. An investigation needs to be done to ensure ash in mash registers for *all* accelerators it needs, including ones only needed for matching of previous_accelerator.

Comment 1 by sky@chromium.org, Jul 22 2016

Blocking: 612331
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e

commit aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e
Author: sky <sky@chromium.org>
Date: Wed Aug 03 00:14:55 2016

Get AcceleratorControllerTest working with mash

A couple of tests have been commented or disabled because of current
lacking functionality in mash. Bugs are filed for all the cases.

BUG= 612331 , 632208 ,632209, 630683 , 632211 , 632180 , 632189 , 632192 , 632200 , 632201 
TEST=AcceleratorControllerTest* in mash_unittests
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2203003003
Cr-Commit-Position: refs/heads/master@{#409393}

[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/BUILD.gn
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_registrar.h
[add] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_registrar_test_api.cc
[add] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_registrar_test_api.h
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_shell_mus.h
[add] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_shell_mus_test_api.h
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/property_util.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/property_util.h
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/test/ash_md_test_base.h
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/test/ash_test_helper.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ui/views/mus/native_widget_mus.cc

Comment 3 by dtapu...@chromium.org, Sep 2 2016

Components: MUS

Comment 4 by rjkroege@chromium.org, Oct 4 2016

Labels: Proj-Mustash

Comment 5 by rjkroege@chromium.org, Oct 4 2016

Components: Internals>MUS

Comment 6 by mfomitchev@chromium.org, Dec 9 2016

Labels: -Proj-Mustash Proj-Mustash-Mash

Comment 7 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService

Comment 8 by lafo...@chromium.org, Feb 26 2018

Components: -MUS

Comment 9 by jamescook@chromium.org, Apr 19 2018

Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash

Comment 10 by sky@chromium.org, Aug 13

Status: WontFix (was: Untriaged)
Now that ash runs the window-service this is no longer an issue.
►

Sign in to add a comment