New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630667 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocked on:
issue 650760



Sign in to add a comment

Punycode in "URL wants to know your location" popup

Reported by szklarsk...@gmail.com, Jul 22 2016

Issue description

Chrome Version       : 51.0.2704.106
URLs (if applicable) : https://żuławiki.pl/ ( https://xn--uawiki-3db67b.pl/ )
Other browsers tested: Firefox OK, Safari OK

What steps will reproduce the problem?
(1) Open https://żuławiki.pl/
(2) Address bar properly shows https://żuławiki.pl/
(3) A message "https://xn--uawiki-3db67b.pl/ wants to know your location" shows up

What is the expected result?
Message should be "https://żuławiki.pl/ wants to know your location"

What happens instead?
Message "https://xn--uawiki-3db67b.pl/ wants to know your location" shows up

Tested on latest chrome on linux mint, android and iphone - all behave the same way.
 
zulawiki.png
593 KB View Download
Cc: tkonch...@chromium.org
Components: UI
Labels: -Pri-3 M-54 OS-Linux OS-Mac OS-Windows Pri-2
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Linux 14.04 chrome version 52.0.2743.82 and canary 54.0.2810.2 - A message "https://xn--uawiki-3db67b.pl/ wants to know your location" shows up

This is working fine in firefox browser - Please find the screenshot

This issue can be seen from M30 builds to latest canary
Issue can be seen on mac and win8.1 as well
Screen Shot 2016-07-29 at 3.33.05 PM.png
343 KB View Download
Working fine in IE 11 on win7 -- see attachment
zulawiki-ie.png
505 KB View Download
Owner: brettw@chromium.org
Status: Assigned (was: Untriaged)
Reproduced locally. It looks like that dialog's code calls straight through to GURL, so maybe GURL is returning a punycoded host.

Over to brettw@ for these questions:
1) Is GURL::host_piece() expected to return punycode?
2) If so, what should one use to turn the string back into a displayable string?

Comment 4 by brettw@chromium.org, Sep 14 2016

Owner: ellyjo...@chromium.org
1) Yes
2) components/url_formatter. Maybe something like AppendFormattedHost() in there.
Status: Started (was: Assigned)
There is a WIP CL for this, pending review from security enamel: https://codereview.chromium.org/2341213004/

Comment 6 by js...@chromium.org, Sep 27 2016

Cc: js...@chromium.org
I noticed this behavior and was a bit puzzled as to why we still show punycode because I thought I had fixed FormatUrlForSecurityDisplay in April (when overhauling IDN display policy). It turned out that somehow I overlooked FormatUrlForSecurity. 

elide_url.h still has this comment for FormatUrlForSecurityDisplay. 

// Internationalized domain names (IDN) may be presented in Unicode if
// they're regarded safe. See |url_formatter::FormatUrl| for more details on
// the algorithm).

Somehow, the above comment and the actual implementation differ from each other. 



Comment 7 by js...@chromium.org, Sep 27 2016

Blockedon: 650760
Cc: -js...@chromium.org ellyjo...@chromium.org
Owner: js...@chromium.org
jshin@: what happened with this? is it fixed now?

Comment 9 by js...@chromium.org, May 26 2017

Status: Fixed (was: Started)
Yes, it's fixed for all LTR domains. For RTL domains, it will still show punycode, which is why bug 650760 is still open. I took a very conservative approach. 

That remaining issue can be dealt with in that bug. I'm closing this bug as fixed. 

Sign in to add a comment