With the inclusion of TabManager on TestingBrowserProcess (http://crrev.com/2121403002) we can now remove all tests that make sure TabManager isn't false not only in production code but also for all tests. https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_tab_util.cc?q=extension_tab&sq=package:chromium&l=394
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23ac43bec939cc186cdb0f27a73ff862671c7a0e commit 23ac43bec939cc186cdb0f27a73ff862671c7a0e Author: andersoncss <andersoncss@google.com> Date: Tue Aug 16 20:23:02 2016 TabManager should be defined in all cases, so we no longer need to defensively check whether or not it is null. BUG= 630645 Review-Url: https://codereview.chromium.org/2245203002 Cr-Commit-Position: refs/heads/master@{#412323} [modify] https://crrev.com/23ac43bec939cc186cdb0f27a73ff862671c7a0e/chrome/browser/memory/tab_manager.cc [modify] https://crrev.com/23ac43bec939cc186cdb0f27a73ff862671c7a0e/chrome/browser/memory/tab_manager_browsertest.cc [modify] https://crrev.com/23ac43bec939cc186cdb0f27a73ff862671c7a0e/chrome/browser/memory/tab_manager_observer_browsertest.cc [modify] https://crrev.com/23ac43bec939cc186cdb0f27a73ff862671c7a0e/chrome/browser/ui/browser.cc
Comment 1 by sheriffbot@chromium.org
, Jul 23 2016