New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 630639 link

Starred by 2 users
Status: Fixed
Owner:
jbudorick@chromium.org
Closed: Jul 2016
Cc:
█ xunji...@chromium.org
tedc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Android Cronet Builder Asan set-up issue

Project Member Reported by timvolod...@chromium.org, Jul 22 2016

Comment 1 by timvolod...@chromium.org, Jul 22 2016 

>> Remounting /system rw
restarting adbd as root
error: protocol fault (couldn't read status): Success
step returned non-zero exit code: 1
@@@STEP_EXCEPTION@@@


--------------------------------------------------------------------------------
started: Fri Jul 22 04:39:07 2016
ended: Fri Jul 22 04:39:07 2016
duration: 0 secs
status: EXCEPTION
status reason:

Comment 2 by timvolod...@chromium.org, Jul 22 2016

Cc: jbudorick@chromium.org
Components: Infra>Labs
apparently this happened occasionally recently, but now failed twice in a row
+cc:infra to verify this is not a device/infra issue

Comment 3 by jbudorick@chromium.org, Jul 22 2016

Cc: xunji...@chromium.org
Components: -Infra>Labs
Owner: jbudorick@chromium.org
Status: Assigned (was: Untriaged)
I added the asan_setup_device.sh step this week, so this is definitely me. Not a labs issue.

+xunjieli FYI

Comment 4 by xunji...@chromium.org, Jul 22 2016

Cc: -jbudorick@chromium.org
Components: Internals>Network>Library
John, thank you very much for taking care of this!

Comment 6 by jbudorick@chromium.org, Jul 22 2016

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/3bed8d87e270fa3615a584b04c2ea23506ba8984

commit 3bed8d87e270fa3615a584b04c2ea23506ba8984
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Jul 22 16:18:12 2016
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/7e7a207e492d63e4d8de90b33e466cb910a463ec

commit 7e7a207e492d63e4d8de90b33e466cb910a463ec
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Jul 22 16:26:28 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/d586d110fcce4de95de41660b820d624835aa8e0 [Android] Use --use-su w/ asan_device_setup.sh. (jbudorick@chromium.org)

R=jbudorick@chromium.org,martiniss@chromium.org,xunjieli@chromium.org
BUG= 630639 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2167373003

[modify] https://crrev.com/7e7a207e492d63e4d8de90b33e466cb910a463ec/infra/config/recipes.cfg
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/3cd833932f64d01944f039a8dcc4b76a1515cf7c

commit 3cd833932f64d01944f039a8dcc4b76a1515cf7c
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Jul 22 16:46:37 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/d586d110fcce4de95de41660b820d624835aa8e0 [Android] Use --use-su w/ asan_device_setup.sh. (jbudorick@chromium.org)
  https://crrev.com/be09b8b990b15e9a6945a8a43aa9fead0c0f1457 Change PGO recipe to use MB now that it supports multiple phases. (dpranke@chromium.org)

R=dpranke@chromium.org,sebmarchand@chromium.org,jbudorick@chromium.org,martiniss@chromium.org,xunjieli@chromium.org
BUG=595947, 630639 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2169343003

[modify] https://crrev.com/3cd833932f64d01944f039a8dcc4b76a1515cf7c/infra/config/recipes.cfg

Comment 10 by jbudorick@chromium.org, Jul 22 2016 

From https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Builder%20Asan/builds/58:

ERROR: Cannot use 'su -c':
$ adb shell su -c "echo foo"
su: exec failed for echo Error:No such file or directory
Check that 'su' binary is correctly installed on the device or omit
            --use-su flag
step returned non-zero exit code: 1

We use su elsewhere, so I'm surprised to see this. Investigating further.

Comment 11 by jbudorick@chromium.org, Jul 22 2016 

... its test for su failed because it couldn't find echo, not because it couldn't use su. X(
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/067206029b23000d0576571967a142e01a587a97

commit 067206029b23000d0576571967a142e01a587a97
Author: jbudorick <jbudorick@chromium.org>
Date: Fri Jul 22 17:33:41 2016

Revert of [Android] Use --use-su w/ asan_device_setup.sh. (patchset #1 id:1 of https://codereview.chromium.org/2169263005/ )

Reason for revert:
su -c echo foo can't find echo.

Original issue's description:
> [Android] Use --use-su w/ asan_device_setup.sh.
>
> This should prevent the script from calling `adb root`, which can result in
> temporary connection issues immediately after it returns.
>
> BUG= 630639 
> TBR=martiniss@chromium.org,xunjieli@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/d586d110fcce4de95de41660b820d624835aa8e0

TBR=martiniss@chromium.org,xunjieli@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 630639 

Review-Url: https://codereview.chromium.org/2174623003

[modify] https://crrev.com/067206029b23000d0576571967a142e01a587a97/scripts/slave/recipe_modules/chromium_android/api.py
[modify] https://crrev.com/067206029b23000d0576571967a142e01a587a97/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan_tester.json
[modify] https://crrev.com/067206029b23000d0576571967a142e01a587a97/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json
[modify] https://crrev.com/067206029b23000d0576571967a142e01a587a97/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/d0608f636c8487336f37d8f850128ce9da23a606

commit d0608f636c8487336f37d8f850128ce9da23a606
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Jul 22 18:08:30 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/067206029b23000d0576571967a142e01a587a97 Revert of [Android] Use --use-su w/ asan_device_setup.sh. (patchset #1 id:1 of https://codereview.chromium.org/2169263005/ ) (jbudorick@chromium.org)
  https://crrev.com/ee1426a78d337cd4715a288e2aef14a77751669b [Android] Root devices before asan_device_setup.sh. (jbudorick@chromium.org)

R=jbudorick@chromium.org,martiniss@chromium.org,xunjieli@chromium.org
BUG= 630639 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2173943002

[modify] https://crrev.com/d0608f636c8487336f37d8f850128ce9da23a606/infra/config/recipes.cfg

Comment 16 by jbudorick@chromium.org, Jul 28 2016

Status: Fixed (was: Started)
No asan setup failures in the last 40+ builds.
►

Sign in to add a comment