Issue metadata
Sign in to add a comment
|
Suggestion window is not dismising when pressing back key |
||||||||||||||||||||
Issue descriptionVersion: Chrome 54.0.2804.0 OS: Android 6.0.1 What steps will reproduce the problem? (1) Launch Chrome (2) Touch on URL bar (Observe IME appears) (3) Start typing some chars (Observe suggestion box appears) (4) Press device Back key (5) Observe IME is dismissed. (6) Press device Back key again. (7) Observe Suggestion box is not dismissed, instead of page navigation occurs in the background. What is the expected output? Suggestion box should consume the back key and dissmiss itself. Future back key event should go to Tab for page navigations. What do you see instead? Suggestion window is not consuming the back key event, when it is visible, instead of Tab is consuming back key. Device used: Samsung Galaxy Note 4
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a24ca6788c61a71cb28089d4b2ab80e506cc50d commit 5a24ca6788c61a71cb28089d4b2ab80e506cc50d Author: ajith.v <ajith.v@chromium.org> Date: Tue Jul 26 04:12:21 2016 Dismissing suggestion window upon receiving BACK key. Currently Tab is consuming the device BACK key even when suggestion window is visible and doing page navigation instead of dismissing suggestion window. Added changes to consume BACK key at suggestion window, so that it can consume BACK key and execute respective actions. BUG= 630633 Review-Url: https://codereview.chromium.org/2174633004 Cr-Commit-Position: refs/heads/master@{#407703} [modify] https://crrev.com/5a24ca6788c61a71cb28089d4b2ab80e506cc50d/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/5a24ca6788c61a71cb28089d4b2ab80e506cc50d/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java [modify] https://crrev.com/5a24ca6788c61a71cb28089d4b2ab80e506cc50d/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
,
Jul 26 2016
,
Aug 4 2016
,
Aug 4 2016
The original change that broke this landed on 53: https://codereview.chromium.org/2108333003 So let's get the fix on 53 as well
,
Aug 4 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aca09e059f9b094dcd3999cfa06d7ec8c3f7258f commit aca09e059f9b094dcd3999cfa06d7ec8c3f7258f Author: Ted Choc <tedchoc@google.com> Date: Thu Aug 04 16:42:54 2016 Dismissing suggestion window upon receiving BACK key. Currently Tab is consuming the device BACK key even when suggestion window is visible and doing page navigation instead of dismissing suggestion window. Added changes to consume BACK key at suggestion window, so that it can consume BACK key and execute respective actions. BUG= 630633 Review URL: https://codereview.chromium.org/2211073002 . Review-Url: https://codereview.chromium.org/2174633004 Cr-Original-Commit-Position: refs/heads/master@{#407703} Cr-Commit-Position: refs/branch-heads/2785@{#502} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/aca09e059f9b094dcd3999cfa06d7ec8c3f7258f/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/aca09e059f9b094dcd3999cfa06d7ec8c3f7258f/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java [modify] https://crrev.com/aca09e059f9b094dcd3999cfa06d7ec8c3f7258f/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ajit...@samsung.com
, Jul 22 2016Labels: OS-Android