New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630627 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Android Galaxy S5 Perf (1) failure on chromium.perf

Project Member Reported by eyaich@chromium.org, Jul 22 2016

Issue description

Sharded perf tests are failing at step 22

Link to most recent failing build: 
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Galaxy%20S5%20Perf%20%281%29/builds/3311


Link to failing log: 
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Galaxy%20S5%20Perf%20%281%29/builds/3311/steps/Sharded%20Perf%20Tests/logs/stdio


Seems to be an issue in the android test runner
 
Log output: 

I 4932.092s Main  Wrote device cache: /b/rr/tmpl9IKYg/w/src/out/Release/device_cache_3208cf5e05b2517f.json
E 4932.093s Main  Unrecognized error occurred.
Traceback (most recent call last):
  File "/b/rr/tmpl9IKYg/w/src/build/android/test_runner.py", line 995, in main
    return RunTestsCommand(args)
  File "/b/rr/tmpl9IKYg/w/src/build/android/test_runner.py", line 818, in RunTestsCommand
    return RunTestsInPlatformMode(args)
  File "/b/rr/tmpl9IKYg/w/src/build/android/test_runner.py", line 891, in RunTestsInPlatformMode
    iteration_results.AddTestRunResults(r)
  File "/b/rr/tmpl9IKYg/w/src/build/android/pylib/base/base_test_result.py", line 183, in AddTestRunResults
    assert isinstance(results, TestRunResults)
AssertionError
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

 
Yeah, we are experimenting with a new perf test runner, adding some logging to see what is going on then will back out the new test runner until I can fix. I need some in the wild logging for this because I never saw it locally. 
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 22 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/20987985f90a1403ca57df2310853ef7836a994f

commit 20987985f90a1403ca57df2310853ef7836a994f
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Jul 22 22:46:23 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/109b217f3aaed1ee8a3deabcee603943aea21082 [Android] Revert Galaxy s5 perf bots to not using platform mode test runner. (rnephew@chromium.org)

R=rnephew@chromium.org
BUG= 630627 , 615157 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2175863004

[modify] https://crrev.com/20987985f90a1403ca57df2310853ef7836a994f/infra/config/recipes.cfg

Comment 5 by picksi@chromium.org, Jul 25 2016

Status: Fixed (was: Untriaged)
This bot remains flaky, but has been green on and off since build #3317.

#1 talks about backing out the new test, which I assumed happened in #2. Is there an ETA for getting the new version of Android test runner landed again?

Comment 6 by picksi@chromium.org, Jul 25 2016

Status: Assigned (was: Fixed)
Sorry, accidentally marked as Fixed!
I am hoping to land it again either today or tomorrow. Some of the failures related to it were around the less logging the new test runner has. Very long running tests were not outputting enough and the tests were timing out without output. I am adding a heartbeat message to stop this from happening.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c4a773fb2b4dc7b71051460a534ae8c0c3ac006

commit 6c4a773fb2b4dc7b71051460a534ae8c0c3ac006
Author: rnephew <rnephew@chromium.org>
Date: Mon Jul 25 21:48:47 2016

[Android] Make perf test runner in platform mode check that return value is not None.

BUG= 630627 , 615157 

Review-Url: https://codereview.chromium.org/2175313003
Cr-Commit-Position: refs/heads/master@{#407598}

[modify] https://crrev.com/6c4a773fb2b4dc7b71051460a534ae8c0c3ac006/build/android/pylib/local/device/local_device_perf_test_run.py

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 25 2016

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/81693cf3baf302312bc2e5b6185c7f2740b339b5

commit 81693cf3baf302312bc2e5b6185c7f2740b339b5
Author: recipe-roller <recipe-roller@chromium.org>
Date: Mon Jul 25 22:27:51 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/772e098a3f629dfeadab58212623a07e54ee902a [Android] Reland Galaxy s5 perf bots to run using platform mode. (rnephew@chromium.org)

R=rnephew@chromium.org
BUG= 630627 , 630640 , 615157 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2178073004

[modify] https://crrev.com/81693cf3baf302312bc2e5b6185c7f2740b339b5/infra/config/recipes.cfg

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/93b972af676e8098ebc020db5600b1197a761982

commit 93b972af676e8098ebc020db5600b1197a761982
Author: jbudorick <jbudorick@chromium.org>
Date: Tue Jul 26 13:44:09 2016

Revert of [Android] Reland Galaxy s5 perf bots to run using platform mode. (patchset #1 id:1 of https://codereview.chromium.org/2177863004/ )

Reason for revert:
the sharded perf tests step fails when one or more devices are blacklisted.

Original issue's description:
> [Android] Reland Galaxy s5 perf bots to run using platform mode.
>
> BUG= 615157 , 630627 , 630640 
>
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/772e098a3f629dfeadab58212623a07e54ee902a

TBR=stip@chromium.org,rnephew@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 615157 , 630627 , 630640 

Review-Url: https://codereview.chromium.org/2187483002

[modify] https://crrev.com/93b972af676e8098ebc020db5600b1197a761982/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/93b972af676e8098ebc020db5600b1197a761982/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[modify] https://crrev.com/93b972af676e8098ebc020db5600b1197a761982/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/93b972af676e8098ebc020db5600b1197a761982/scripts/slave/recipes/android/perf.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 26 2016

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/5b9186bb318fad23806c4115489984ef1a58e828

commit 5b9186bb318fad23806c4115489984ef1a58e828
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 26 14:08:05 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/93b972af676e8098ebc020db5600b1197a761982 Revert of [Android] Reland Galaxy s5 perf bots to run using platform mode. (patchset #1 id:1 of https://codereview.chromium.org/2177863004/ ) (jbudorick@chromium.org)

R=jbudorick@chromium.org,rnephew@chromium.org,stip@chromium.org
BUG= 630627 , 630640 , 615157 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2178213004

[modify] https://crrev.com/5b9186bb318fad23806c4115489984ef1a58e828/infra/config/recipes.cfg

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b506bd9515fe22c04f5bdd77e1024efdb7f5274c

commit b506bd9515fe22c04f5bdd77e1024efdb7f5274c
Author: rnephew <rnephew@chromium.org>
Date: Tue Jul 26 16:36:26 2016

[Android] Fix perf test runner in platform mode return value for when devices are blacklisted.

BUG= 630627 , 615157 

Review-Url: https://codereview.chromium.org/2187513002
Cr-Commit-Position: refs/heads/master@{#407829}

[modify] https://crrev.com/b506bd9515fe22c04f5bdd77e1024efdb7f5274c/build/android/pylib/local/device/local_device_perf_test_run.py

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/525217b0d1284f1b2a9ddd691b099f9a4f894349

commit 525217b0d1284f1b2a9ddd691b099f9a4f894349
Author: rnephew <rnephew@chromium.org>
Date: Tue Jul 26 16:44:46 2016

Reland of [Android] Reland Galaxy s5 perf bots to run using platform mode. (patchset #1 id:1 of https://codereview.chromium.org/2187483002/ )

Reason for revert:
Fixed with https://codereview.chromium.org/2187513002/

Original issue's description:
> Revert of [Android] Reland Galaxy s5 perf bots to run using platform mode. (patchset #1 id:1 of https://codereview.chromium.org/2177863004/ )
>
> Reason for revert:
> the sharded perf tests step fails when one or more devices are blacklisted.
>
> Original issue's description:
> > [Android] Reland Galaxy s5 perf bots to run using platform mode.
> >
> > BUG= 615157 , 630627 , 630640 
> >
> > Committed: https://chromium.googlesource.com/chromium/tools/build/+/772e098a3f629dfeadab58212623a07e54ee902a
>
> TBR=stip@chromium.org,rnephew@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 615157 , 630627 , 630640 
>
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/93b972af676e8098ebc020db5600b1197a761982

TBR=stip@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 615157 , 630627 , 630640 

Review-Url: https://codereview.chromium.org/2184803002

[modify] https://crrev.com/525217b0d1284f1b2a9ddd691b099f9a4f894349/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/525217b0d1284f1b2a9ddd691b099f9a4f894349/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[modify] https://crrev.com/525217b0d1284f1b2a9ddd691b099f9a4f894349/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/525217b0d1284f1b2a9ddd691b099f9a4f894349/scripts/slave/recipes/android/perf.py

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 26 2016

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/374c564fecdd069a6c1b0bf73b6541f21d6dee2f

commit 374c564fecdd069a6c1b0bf73b6541f21d6dee2f
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 26 17:06:05 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/525217b0d1284f1b2a9ddd691b099f9a4f894349 Reland of [Android] Reland Galaxy s5 perf bots to run using platform mode. (patchset #1 id:1 of https://codereview.chromium.org/2187483002/ ) (rnephew@chromium.org)

R=rnephew@chromium.org,jbudorick@chromium.org,stip@chromium.org
BUG= 630627 , 630640 , 615157 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2178353004

[modify] https://crrev.com/374c564fecdd069a6c1b0bf73b6541f21d6dee2f/infra/config/recipes.cfg

Status: Fixed (was: Assigned)

Sign in to add a comment