Regression: [History]'Remove selected items' overlay doesn't dismiss after clicking on back navigation button.
Reported by
dchau...@etouch.net,
Jul 22 2016
|
|||||
Issue descriptionChrome Version: 54.0.2803.0 (Official Build)74ed884d4d42cb7152dc75fae33351e8e34220cd-refs/heads/master@{#406716} 32/64-bit. OS: Windows(7,8,10), Linux (Ubuntu 14.04 LTS),Mac(10.10.5,10.11.4). Precondition: Create some history in browser. What steps will reproduce the problem? 1. Launch chrome and then navigate to chrome://history page. 2. Click on 'Action' icon of any URL and select 'More from this site' option. 3. Select the checkbox of any URL and click on 'DELETE' button on toolbar. 4. Now, press back navigation button and observe. 'Remove selected items' overlay doesn't dismiss after clicking on back navigation button. 'Remove selected items' overlay should get dismissed after clicking on back navigation button. This is a regression issue, broken in M-54 series, below is bisect info. Good build: 54.0.2802.0 Bad build: 54.0.2803.0 Narrow bisect; https://chromium.googlesource.com/chromium/src/+log/d8232ee902862b691d958d5cc66670a8fd9f4e0c..bb921dfc13aad262dfff7270a8949b6032c6fb23?pretty=fuller&n=100 Suspecting: r406515 Kindly review the attached screen-cast for reference.
,
Jul 27 2016
calamity@: Could you please take a look and update this blocker issue.
,
Jul 28 2016
,
Jul 29 2016
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d639e4a5bc4f451b24917d19818eadf15d016095 commit d639e4a5bc4f451b24917d19818eadf15d016095 Author: calamity <calamity@chromium.org> Date: Wed Aug 03 06:48:27 2016 [MD History] Close delete items dialog when a new query is initiated. This CL fixes an issue where the dialog in MD History would stay open when the user pressed the Back button in the browser. As a catchall, the dialog will now close when any non-incremental query is initiated. BUG= 630584 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2186073003 Cr-Commit-Position: refs/heads/master@{#409472} [modify] https://crrev.com/d639e4a5bc4f451b24917d19818eadf15d016095/chrome/browser/resources/md_history/list_container.js [modify] https://crrev.com/d639e4a5bc4f451b24917d19818eadf15d016095/chrome/test/data/webui/md_history/history_list_test.js
,
Aug 3 2016
,
Aug 9 2016
Tested the issue on Windows 7, Mac 10.11.6 using 54.0.2824.0, Ubuntu 14.04 using 54.0.2823.0(as unable to verify the fix on linux 54.0.2824.0 due to bug 635768).Observed that 'Remove selected items' overlay got dismissed after clicking on back navigation button. Please find attached screencast. Marking it as TE-Verified. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ranjitkan@chromium.org
, Jul 22 2016