Unnecessary vertical scroll bar is seen after entering and exiting fullscreen on xfinity.com
Reported by
adha...@etouch.net,
Jul 22 2016
|
|||||||||
Issue descriptionVersion:Chrome version : 54.0.2803.0 (Official Build) 74ed884d4d42cb7152dc75fae33351e8e34220cd-refs/heads/master@{#406716} (32/64 bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4) Test URL:http://www.xfinity.com/ What steps will reproduce the problem? (1)Launch chrome and navigate to the above URL. (2)Scroll down the page and click on the video under 'What is XFINITY® X1?' section. (3)Play the video,click on full screen icon then click F11. (4)Observe. Actual:Unnecessary vertical scroll bar is seen after step 3. Expected:No such vertical scroll bar should be seen after step 3. This is a Regression issue broken in M-54,below is the Change log: https://chromium.googlesource.com/chromium/src/+log/54.0.2796.0..54.0.2797.0?pretty=fuller&n=10000 Suspecting:r405656? Good build:54.0.2796.0 Bad build:54.0.2797.0 Note:Unable to perform Flash bisect for above issue as issue is not playing in chromium build. Kindly help to re-assign if your change is not the cause for this issue.
,
Jul 22 2016
The above issue is reproducible on latest canary chrome version : 54.0.2804.0.
,
Jul 22 2016
I haven't made any UI related changes. Frank, can you take a look? FYI: I was not able to repro the issue on Mac OSX 10.11.5, Chrome 54.0.2803.0 (Official Build) canary (64-bit).
,
Jul 22 2016
yeah, i'll take a look.
,
Jul 22 2016
i can repro on linux ~@ToT. i'll bisect.
,
Jul 22 2016
it works in 2797 and breaks by 2798. still bisecting.
,
Jul 25 2016
foolip: https://codereview.chromium.org/2107233002 seems to be the cause. re-assigning.
,
Jul 25 2016
https://chromium.googlesource.com/chromium/src/+/d666f503ae854fac360cc70da1f5971a6724546a is in the bisect range and that has already been reverted, so this looks like more fallout from issue 240576 , but I actually can't reproduce it on a build before the revert. Does this manifest on Mac, and do you have a screen recording?
,
Jul 27 2016
,
Jul 27 2016
OK, I can reproduce this on Linux, and can confirm that it's because of https://codereview.chromium.org/2107233002. You can reproduce it (before the revert in https://codereview.chromium.org/2168373002) without using F11, you can use the page-provided fullscreen button to enter and exit to observe the same thing. Will try to minimize to a test case so that it can't be regressed on the next top layer attempt.
,
Jul 28 2016
OK, so after two long sessions minimizing xfinity.com, this is the smallest I can make the problem: <!DOCTYPE html> <style> @font-face { font-family: "x"; src: url("404"); } body { line-height: 1; overflow-x: hidden; } </style> <div onclick="event.target.webkitRequestFullscreen()">click here<br>then exit fullscreen</div> <div></div> At least on Linux, with the top layer rewrite applied, after exiting fullscreen there's a small scrollbar to the right. The scrollbars appear to be on the body element, so it might have something to do with the logic to suppress scrollbars in fullscreen. Since this has already been reverted I'm removing ReleaseBlock-Stable, but leaving it open so that I can make sure this is fixed with the next attempt.
,
Aug 5 2016
Verified the issue on latest canary 54.0.2820.0 and its working fine on Mac 10.11.6,Win 7 and Ubuntu 14.04 by following the Steps from original report. foolip@ : Could you please review the attached screen cast once. If there is no further work to be done on it please mark the issue to Fixed.
,
Aug 9 2016
,
Aug 9 2016
Closing, but will need to recheck that the regression doesn't happen next time top layer is landed.
,
Oct 26 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ranjitkan@chromium.org
, Jul 22 2016