New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630568 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 570453
issue 429053



Sign in to add a comment

Clean DEPTH_STENCIL issues in command buffer

Project Member Reported by qiankun....@intel.com, Jul 22 2016

Issue description

In ES3.0 DEPTH_STENCIL is an alias for setting and querying both the depth and stencil attachments. Operations on DEPTH_STENCIL such as FramebufferTexture2D, FramebufferRenderbuffer are split into two calls for depth and stencil. But depth_stencil attachment is still saved in Framebuffer other than two attachments(depth and stencil). See some discussions in 
https://codereview.chromium.org/2171543002/.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/761e2ddaa6d3aea34848809174a250291b2615a5

commit 761e2ddaa6d3aea34848809174a250291b2615a5
Author: kbr <kbr@chromium.org>
Date: Wed Oct 05 02:43:54 2016

Move special DEPTH_STENCIL attachment logic from command buffers to WebGL1

(piman's https://codereview.chromium.org/2372953002/ , conflicts resolved)

GL_DEPTH_STENCIL_ATTACHMENT is not a real attachment in ES3, but instead is
translated to separate DEPTH and STENCIL attachment. However, WebGL1 has a
concept of a separate DEPTH_STENCIL attachment that is mutually exclusive with
DEPTH and STENCIL attachments.
This CL moves the logic that tracks the separate DEPTH_STENCIL attachment to the
WebGL side, so that the ES3 implementation can consistently track which
attachment is active, in accordance to ES3 rules.

BUG= 630568 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2389363002
Cr-Commit-Position: refs/heads/master@{#423054}

[modify] https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5/gpu/command_buffer/common/gles2_cmd_utils.cc
[modify] https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5/gpu/command_buffer/service/context_group.cc
[modify] https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5/gpu/command_buffer/service/framebuffer_manager.cc
[modify] https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5/gpu/command_buffer/service/framebuffer_manager.h
[modify] https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5/gpu/command_buffer/service/framebuffer_manager_unittest.cc
[modify] https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
[modify] https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5/gpu/command_buffer/service/texture_manager_unittest.cc
[modify] https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp
[modify] https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h
[modify] https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Comment 2 by piman@chromium.org, Oct 11 2016

Status: Fixed (was: Assigned)

Comment 3 by kbr@chromium.org, Oct 20 2016

Owner: piman@chromium.org
Moving owner to piman as the author of the patch.

Comment 4 by kbr@chromium.org, Oct 20 2016

Blocking: 570453

Sign in to add a comment