New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 630554 link

Starred by 3 users
Status: Fixed
Owner:
█ kozyatinskiy@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Blackboxing a script update this stacktrace only after blackboxing another script

Reported by dam...@dam.io, Jul 22 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2783.2 Safari/537.36

Steps to reproduce the problem:
1. open dev tools
2. pause with a stacktrace having many scripts
3. select "blackbox script" with the context menu on a stacktrace line

Video: https://vid.me/5V2W

What is the expected behavior?
Script should be hidden from stracktrace directly

What went wrong?
Script doesn't disappear and you have to wait until blackboxing another script for it to disappear

Did this work before? N/A 

Chrome version: 53.0.2783.2  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 22.0 r0

Comment 1 by caseq@chromium.org, Jul 22 2016

Components: -Platform>DevTools Platform>DevTools>JavaScript
Owner: kozyatinskiy@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by kozyatinskiy@chromium.org, Dec 2 2016

Labels: Hotlist-Polish
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdeae63b378752373d7ea31f1feadc621f941e17

commit bdeae63b378752373d7ea31f1feadc621f941e17
Author: dgozman <dgozman@chromium.org>
Date: Fri Jan 20 03:50:52 2017

[DevTools] Migrate CallStackSidebarPane to UI.ListControl.

This pane is one of the two clients of UIList, which is going
to be replaced by UI.ListControl.

This patch also moves call stacks pane to shadow dom.

BUG= chromium:630554 

Review-Url: https://codereview.chromium.org/2609653002
Cr-Commit-Position: refs/heads/master@{#444971}

[modify] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-change-variable.html
[modify] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe.html
[modify] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused.html
[modify] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-async-function.html
[modify] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url.html
[modify] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/copy-stack-trace-expected.txt
[modify] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
[modify] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
[add] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/Source/devtools/front_end/sources/callStackSidebarPane.css
[modify] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/Source/devtools/front_end/sources/module.json
[modify] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css
[modify] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/bdeae63b378752373d7ea31f1feadc621f941e17/third_party/WebKit/Source/devtools/front_end/ui/ListControl.js

Comment 4 by kozyatinskiy@chromium.org, Jan 20 2017

Status: Fixed (was: Assigned)

Comment 5 by kayce@google.com, Jan 26 2017

Labels: DevTools-Release-Notes-Feature
►

Sign in to add a comment