Suspect: https://chromium.googlesource.com/chromium/src/+/ea728cb128c672e9cb9c99c16c00206575584d0a

(only CL touching PageLoad in the first batch when the failure appeared)

Will try to revert.

(+cc sheriffs FYI)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ea2c7581324e29bf1106af332e3124a17562dbd

commit 6ea2c7581324e29bf1106af332e3124a17562dbd
Author: msramek <msramek@chromium.org>
Date: Fri Jul 22 09:44:28 2016

Revert "Remove non-immediate core page load metrics"

This reverts commit ea728cb128c672e9cb9c99c16c00206575584d0a.

Reason for revert: Broken Linux ChromiumOS Tests.

TBR=bmcquade@chromium.org,shivanisha@chromium.org,isherman@chromium.org
BUG= 630549 

Review-Url: https://codereview.chromium.org/2172183002
Cr-Commit-Position: refs/heads/master@{#407113}

[modify] https://crrev.com/6ea2c7581324e29bf1106af332e3124a17562dbd/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/6ea2c7581324e29bf1106af332e3124a17562dbd/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/6ea2c7581324e29bf1106af332e3124a17562dbd/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6ea2c7581324e29bf1106af332e3124a17562dbd/tools/metrics/histograms/histograms.xml

The bot is green again.

Reopening this, because it was something else that greened the bot for a while. The revert actually hasn't made it to a build yet...

This bot is still failing on the same test.
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29

Will take a look.

Adding label so it appears in the sheriff queue / I don't have to keep tracking down this bug number.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/810c47d4645d63abbda6bbdc11b617115d755bd6

commit 810c47d4645d63abbda6bbdc11b617115d755bd6
Author: bmcquade <bmcquade@chromium.org>
Date: Fri Jul 22 21:03:25 2016

Fix flaky MetricsWebContentsObserverBrowserTests

This reverts commit 58ac1adec45fcd08d91d2c09e0b2c17ed3d181cf, which
disabled a few flaky tests, and fixes those tests so they are no longer
flaky.

In a follow up change, we'll roll back
https://codereview.chromium.org/2172183002
since this change addresses the flakes caused by that patch.

BUG= 630549 

Review-Url: https://codereview.chromium.org/2176803002
Cr-Commit-Position: refs/heads/master@{#407260}

[modify] https://crrev.com/810c47d4645d63abbda6bbdc11b617115d755bd6/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Hmm, this appears to continue to be flaky despite what I thought was a fix. I'll disable all 3 tests for now, until I can be sure I understand the problem & have a fix.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b03f78c08072600433f7009401f0f040d22cd0a

commit 6b03f78c08072600433f7009401f0f040d22cd0a
Author: bmcquade <bmcquade@chromium.org>
Date: Sat Jul 23 01:08:01 2016

Disable flaky MetricsWebContentsObserverBrowserTests

BUG= 630549 
TBR=csharrison

Review-Url: https://codereview.chromium.org/2171303005
Cr-Commit-Position: refs/heads/master@{#407326}

[modify] https://crrev.com/6b03f78c08072600433f7009401f0f040d22cd0a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

I disabled the failing test, but it continues to fail on this particular bot. I believe the bot may not be updating and continuing to build at an old revision. I filed a bug for this here: https://bugs.chromium.org/p/chromium/issues/detail?id=630833

The flaky test has been disabled; removing this bug from sheriffing queue because we sheriffs' no longer need to track it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0338f99bca56370f27ba0d785c2f168264a9acd

commit c0338f99bca56370f27ba0d785c2f168264a9acd
Author: bmcquade <bmcquade@chromium.org>
Date: Wed Jul 27 17:04:11 2016

Revert "Disable flaky MetricsWebContentsObserverBrowserTests"

This reverts commit 6b03f78c08072600433f7009401f0f040d22cd0a.

These tests were originally flaky, but that was fixed in
https://codereview.chromium.org/2176803002.

Unfortunately, at the time the fix was landed, one of the bots
was in a bad state, and continued to report failures despite
the fix. At the time, to be conservative, we disabled these tests.
The broken bot has since been fixed, so we can now re-enable
these tests.

BUG= 630549 

Review-Url: https://codereview.chromium.org/2186933002
Cr-Commit-Position: refs/heads/master@{#408159}

[modify] https://crrev.com/c0338f99bca56370f27ba0d785c2f168264a9acd/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdb7c3816e4a396f6f680bfb33c9a496179c471b

commit bdb7c3816e4a396f6f680bfb33c9a496179c471b
Author: bmcquade <bmcquade@chromium.org>
Date: Thu Jul 28 02:35:21 2016

Re-land "Remove non-immediate core page load metrics"

This reverts commit 6ea2c7581324e29bf1106af332e3124a17562dbd.

When this patch was originally landed in
https://codereview.chromium.org/2156093002, it caused some
page load metrics browser tests to fail. Those issues have
since been addressed in
https://codereview.chromium.org/2176803002, so we're ready
to land this change again.

BUG= 630549 

Review-Url: https://codereview.chromium.org/2191633002
Cr-Commit-Position: refs/heads/master@{#408316}

[modify] https://crrev.com/bdb7c3816e4a396f6f680bfb33c9a496179c471b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/bdb7c3816e4a396f6f680bfb33c9a496179c471b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/bdb7c3816e4a396f6f680bfb33c9a496179c471b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/bdb7c3816e4a396f6f680bfb33c9a496179c471b/tools/metrics/histograms/histograms.xml