depot_tools doesn't recognize NetBSD
Reported by
krytarow...@gmail.com,
Jul 22 2016
|
||||||
Issue description
UserAgent: Mozilla/5.0 (X11; NetBSD amd64; rv:45.0) Gecko/20100101 Firefox/45.0
Steps to reproduce the problem:
1. gclient fetch
2. gclient sync
3.
What is the expected behavior?
Functional commands of depot_tools on NetBSD host.
What went wrong?
$ gclient sync
Syncing projects: 100% (78/78), done.
________ running '/usr/pkg/bin/python2.7 src/build/landmines.py' in '/public/chromium'
Traceback (most recent call last):
File "src/build/landmines.py", line 148, in <module>
sys.exit(main())
File "src/build/landmines.py", line 132, in main
if landmine_utils.builder() in ('dump_dependency_json', 'eclipse'):
File "/public/chromium/src/build/landmine_utils.py", line 20, in inner
ret = func()
File "/public/chromium/src/build/landmine_utils.py", line 120, in builder
assert False, 'Don\'t know what builder we\'re using!'
AssertionError: Don't know what builder we're using!
Error: Command '/usr/pkg/bin/python2.7 src/build/landmines.py' returned non-zero exit status 1 in /public/chromium
$ gclient sync
Syncing projects: 100% (78/78), done.
________ running '/usr/pkg/bin/python2.7 src/build/landmines.py' in '/public/chromium'
________ running '/usr/pkg/bin/python2.7 src/tools/remove_stale_pyc_files.py src/android_webview/tools src/build/android src/gpu/gles2_conform_support src/infra src/ppapi src/printing src/third_party/catapult src/third_party/closure_compiler/build src/third_party/WebKit/Tools/Scripts src/tools' in '/public/chromium'
________ running '/usr/pkg/bin/python2.7 src/build/download_nacl_toolchains.py --mode nacl_core_sdk sync --extract' in '/public/chromium'
Traceback (most recent call last):
File "src/build/download_nacl_toolchains.py", line 61, in <module>
sys.exit(Main(sys.argv[1:]))
File "src/build/download_nacl_toolchains.py", line 55, in Main
package_version.main(args)
File "/public/chromium/src/native_client/build/package_version/package_version.py", line 1288, in main
arguments = ParseArgs(args)
File "/public/chromium/src/native_client/build/package_version/package_version.py", line 1115, in ParseArgs
host_platform = pynacl.platform.GetOS()
File "/public/chromium/src/native_client/pynacl/platform.py", line 44, in GetOS
assert platform in OS_DICT, "Unrecognized OS platform: %s" % platform
AssertionError: Unrecognized OS platform: netbsd7
Error: Command '/usr/pkg/bin/python2.7 src/build/download_nacl_toolchains.py --mode nacl_core_sdk sync --extract' returned non-zero exit status 1 in /public/chromium
Did this work before? No
Chrome version: Recent Channel: dev
OS Version: NetBSD-7.99.28
Flash Version: None
Fix:
chieftec$ git diff .
diff --git a/pynacl/platform.py b/pynacl/platform.py
index ae5362d..dabd1f5 100644
--- a/pynacl/platform.py
+++ b/pynacl/platform.py
@@ -29,7 +29,7 @@ OS_LIST = [
OS_MAP = {
OS_WIN: ('win', 'win32', 'cygwin'),
OS_MAC: ('mac', 'darwin'),
- OS_LINUX: ('linux', 'linux2', 'linux3'),
+ OS_LINUX: ('linux', 'linux2', 'linux3', 'netbsd'),
}
OS_DICT = dict([(platform, os_name)
chieftec$ git diff .
diff --git a/build/landmine_utils.py b/build/landmine_utils.py
index 6d18b6d..45e3ec7 100644
--- a/build/landmine_utils.py
+++ b/build/landmine_utils.py
@@ -33,7 +33,7 @@ def IsWindows():
@memoize()
def IsLinux():
- return sys.platform.startswith(('linux', 'freebsd', 'openbsd'))
+ return sys.platform.startswith(('linux', 'freebsd', 'netbsd', 'openbsd'))
@memoize()
,
Jul 22 2016
,
Jul 30 2016
,
Sep 1 2016
,
Sep 4 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 5 2017
We don't compile or test chromium on NetBSD, so we don't plan to have our tools support it either. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by krytarow...@gmail.com
, Jul 22 2016