New issue
Advanced search Search tips

Issue 630487 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 2016
Cc:
alancutter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 442163



Sign in to add a comment

Clean up assert in CSSLengthInterpolationType::apply

Project Member Reported by suzyh@chromium.org, Jul 22 2016 
CSSLengthInterpolationType::apply contains an "#if ENABLE(ASSERT)" clause that references AnimatableValue.

alancutter:
"""
The comment for it is wrong however, it's not comparing this code path with AnimatedStyleBuilder's, instead it's comparing the fast path with the slow path just below. It's not necessary to use AnimatableValues here either, it colud use LengthPropertyFunctions::getLength() instead.
"""

This is a minor code health issue but is technically blocking the complete removal of AnimatableValue ( issue 442163 ).

Comment 1 by alancutter@chromium.org, Jul 22 2016 

Now "colud" is even more cemented in history. D:
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/830c24aa142db9bb04ca3ca74fce50636dd724b7

commit 830c24aa142db9bb04ca3ca74fce50636dd724b7
Author: alancutter <alancutter@chromium.org>
Date: Wed Sep 07 05:27:45 2016

Use CSSPrimitiveValue::create in CSSLengthInterpolationType

This change removes unnecessary code to convert an interpolable length
into a CSS value by reusing existing code that converts a Length object
into a CSSPrimitiveValue.
This change also fixes up the assertion in CSSLengthInterpolationType::apply
to not depend on AnimatableValues as well as making the surrounding comment
more accurate as to its intentions.

BUG= 630487 

Review-Url: https://codereview.chromium.org/2314453002
Cr-Commit-Position: refs/heads/master@{#416851}

[modify] https://crrev.com/830c24aa142db9bb04ca3ca74fce50636dd724b7/third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp
[modify] https://crrev.com/830c24aa142db9bb04ca3ca74fce50636dd724b7/third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp
[modify] https://crrev.com/830c24aa142db9bb04ca3ca74fce50636dd724b7/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
[modify] https://crrev.com/830c24aa142db9bb04ca3ca74fce50636dd724b7/third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp
[modify] https://crrev.com/830c24aa142db9bb04ca3ca74fce50636dd724b7/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp
[modify] https://crrev.com/830c24aa142db9bb04ca3ca74fce50636dd724b7/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h
[modify] https://crrev.com/830c24aa142db9bb04ca3ca74fce50636dd724b7/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp
[modify] https://crrev.com/830c24aa142db9bb04ca3ca74fce50636dd724b7/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
[modify] https://crrev.com/830c24aa142db9bb04ca3ca74fce50636dd724b7/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
[modify] https://crrev.com/830c24aa142db9bb04ca3ca74fce50636dd724b7/third_party/WebKit/Source/core/animation/FilterInterpolationFunctions.cpp
[modify] https://crrev.com/830c24aa142db9bb04ca3ca74fce50636dd724b7/third_party/WebKit/Source/core/animation/ShadowInterpolationFunctions.cpp

Comment 3 by alancutter@chromium.org, Sep 7 2016

Status: Fixed (was: Available)
►

Sign in to add a comment