New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630482 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
M52



Sign in to add a comment

moblab setup wizard typo

Project Member Reported by ntang@google.com, Jul 22 2016

Issue description

There is a typo in the moblab setup wizard. Boto key "secrete" should be "secret"
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 22 2016

Labels: Hotlist-Google

Comment 2 by hadd...@google.com, Jul 22 2016

Also I would suggest changing 

"Device is rebooted for new change to take effect."

to

"Device will now reboot.  This will apply changes."
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/78ae5c7d98752d93984b2091e892bc6b2591e252

commit 78ae5c7d98752d93984b2091e892bc6b2591e252
Author: Michael Tang <ntang@google.com>
Date: Fri Jul 22 00:55:00 2016

Fixed the type "secrete".

BUG= chromium:630482 
TEST=Manual.

Change-Id: I06071b08641334838e2cf17c8a3292b463ceef96
Reviewed-on: https://chromium-review.googlesource.com/362447
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/78ae5c7d98752d93984b2091e892bc6b2591e252/frontend/client/src/autotest/moblab/wizard/CloudStorageCard.java

Comment 4 by ntang@google.com, Jul 22 2016

Cc: krk@chromium.org
Labels: Merge-Request-52 OS-Chrome
Owner: ntang@chromium.org
Status: Fixed (was: Untriaged)

Comment 5 by ntang@google.com, Jul 22 2016

Status: Started (was: Fixed)
I will fix the wording on reboot later.
Labels: Merge-Approved-52

Comment 7 by dimu@chromium.org, Jul 23 2016

Labels: -Merge-Request-52 Merge-Review-52 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M52, manual review required.

Comment 8 by krk@chromium.org, Jul 25 2016

Labels: M52
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 25 2016

Labels: merge-merged-release-R52-8350.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/449a25670f7ca7d03f12116ea00e672f4652dae5

commit 449a25670f7ca7d03f12116ea00e672f4652dae5
Author: Michael Tang <ntang@google.com>
Date: Fri Jul 22 00:55:00 2016

Fixed the type "secrete".

BUG= chromium:630482 
TEST=Manual.

Change-Id: I06071b08641334838e2cf17c8a3292b463ceef96
Reviewed-on: https://chromium-review.googlesource.com/362447
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
(cherry picked from commit 78ae5c7d98752d93984b2091e892bc6b2591e252)
Reviewed-on: https://chromium-review.googlesource.com/362658
Reviewed-by: Krk Mohan <krk@google.com>
Reviewed-by: Mohan Konduri <krk@chromium.org>
Commit-Queue: Michael Tang <ntang@chromium.org>
Trybot-Ready: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/449a25670f7ca7d03f12116ea00e672f4652dae5/frontend/client/src/autotest/moblab/wizard/CloudStorageCard.java

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/449a25670f7ca7d03f12116ea00e672f4652dae5

commit 449a25670f7ca7d03f12116ea00e672f4652dae5
Author: Michael Tang <ntang@google.com>
Date: Fri Jul 22 00:55:00 2016

Fixed the type "secrete".

BUG= chromium:630482 
TEST=Manual.

Change-Id: I06071b08641334838e2cf17c8a3292b463ceef96
Reviewed-on: https://chromium-review.googlesource.com/362447
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
(cherry picked from commit 78ae5c7d98752d93984b2091e892bc6b2591e252)
Reviewed-on: https://chromium-review.googlesource.com/362658
Reviewed-by: Krk Mohan <krk@google.com>
Reviewed-by: Mohan Konduri <krk@chromium.org>
Commit-Queue: Michael Tang <ntang@chromium.org>
Trybot-Ready: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/449a25670f7ca7d03f12116ea00e672f4652dae5/frontend/client/src/autotest/moblab/wizard/CloudStorageCard.java

Project Member

Comment 11 by sheriffbot@chromium.org, Jul 26 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by sheriffbot@chromium.org, Jul 30 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 13 by ntang@google.com, Aug 17 2016

Labels: -Merge-Approved-52

Comment 14 by ntang@google.com, Oct 31 2016

Status: Fixed (was: Started)

Comment 15 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 16 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 17 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 18 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 20 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment