New issue
Advanced search Search tips

Issue 630478 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 630179



Sign in to add a comment

MacViews: [tracker] "Phase 1b": Controls (implement "harmony" look and feel for views controls on Mac)

Project Member Reported by tapted@chromium.org, Jul 22 2016

Issue description

RVG since this is early stages and might have a separate launch bug

"Harmony" is the MD-inspired cross-platform look and feel that will replace "Shiny Modern" (see  Issue 603372 ). It might end up being called something other than "Harmony".

Attaching some early stage mocks to get an idea.
 
Screen Shot 2016-07-22 at 10.19.41 AM.png
68.3 KB View Download
Screen Shot 2016-07-22 at 10.20.38 AM.png
46.4 KB View Download
Screen Shot 2016-07-22 at 10.20.51 AM.png
42.1 KB View Download
Screen Shot 2016-07-22 at 10.20.59 AM.png
28.7 KB View Download
Screen Shot 2016-07-22 at 10.21.31 AM.png
67.7 KB View Download
Screen Shot 2016-07-22 at 10.21.46 AM.png
36.6 KB View Download

Comment 1 by tapted@chromium.org, Jul 22 2016

Blocking: 630179
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e644cd132e1d7b288e0d2bbb9ea34e9a0a50ab6

commit 5e644cd132e1d7b288e0d2bbb9ea34e9a0a50ab6
Author: tapted <tapted@chromium.org>
Date: Wed Aug 03 21:49:30 2016

MacViews: Bump up the default font sizes for dialogs to 12pt.

Previously we used 11pt ([NSFont smallSystemFontSize]), to be consistent
with the Cocoa bookmarks bubble. However, other Cocoa dialogs are using
12pt, and the latest cross-platform UI specs are converging on 12pt.
(There's also general agreement that 11pt it too small).

Since the "Base" font on Mac is [NSFont systemFontSize] -- 13pt -- we
still need to adjust it compared to other platforms in
ui/base/default_style.h. Cocoa UI isn't using these constants yet, so
this only affects MacViews dialogs.

BUG= 632210 ,  564879 ,  630478 

Review-Url: https://codereview.chromium.org/2200833006
Cr-Commit-Position: refs/heads/master@{#409633}

[modify] https://crrev.com/5e644cd132e1d7b288e0d2bbb9ea34e9a0a50ab6/ui/base/default_style.h

Owner: ellyjo...@chromium.org
Status: Assigned (was: Available)

Comment 4 by tapted@chromium.org, Dec 12 2016

Blockedon: -629958

Comment 5 by tapted@chromium.org, Dec 12 2016

Labels: -Restrict-View-Google
Status: Fixed (was: Assigned)
I think the control L&F we care about for Harmony release are dealt with. New bugs should block  Issue 603386 .

Sign in to add a comment