New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630472 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 614440



Sign in to add a comment

create new sad tab page for out of memory errors

Project Member Reported by wfh@chromium.org, Jul 22 2016

Issue description

This bug is to track the creation of a new/special Sad Tab page for Out of Memory errors.

 

Comment 1 by wfh@chromium.org, Jul 22 2016

Blockedon: 614440

Comment 2 by wfh@chromium.org, Jul 22 2016

Proposed CL https://codereview.chromium.org/2172013002/

mock attached.
2016-07-21.png
33.1 KB View Download

Comment 4 by wfh@chromium.org, Jul 27 2016

Labels: M-54
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48c487e61345a4b96040d04e7cdc59b38c49c891

commit 48c487e61345a4b96040d04e7cdc59b38c49c891
Author: wfh <wfh@chromium.org>
Date: Wed Jul 27 22:48:47 2016

Label sandbox job object OOM as OOM in process termination.

BUG= 614440 , 630472 
TEST=go to chrome://memory-exhaust on 64-bit Chrome and verify it gives the OOM sad tab.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2191643002
Cr-Commit-Position: refs/heads/master@{#408259}

[modify] https://crrev.com/48c487e61345a4b96040d04e7cdc59b38c49c891/base/process/kill.h
[modify] https://crrev.com/48c487e61345a4b96040d04e7cdc59b38c49c891/base/process/kill_win.cc
[modify] https://crrev.com/48c487e61345a4b96040d04e7cdc59b38c49c891/content/app/content_main_runner.cc
[modify] https://crrev.com/48c487e61345a4b96040d04e7cdc59b38c49c891/sandbox/win/src/sandbox_types.h

Comment 6 by wfh@chromium.org, May 18 2017

Status: Fixed (was: Started)

Sign in to add a comment