Issue metadata
Sign in to add a comment
|
13.5% regression in blink_perf.layout at 406478:406502 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 21 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9006484974162882752
,
Jul 21 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9006484957344895536
,
Jul 22 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : [CSS Grid Layout] Handle alignment with orthogonal flows Author : jfernandez Commit description: Now that grid sizing and positioning issues wrt orthogonal flows have been clarified in the last spec draft, we can adapt now our alignment logic to work with orthogonal flows. Even though basic alignment would work with orthogonal flows with this patch, we still doesn't allow stretching in that case. I'll provide a patch for that feature since it's a complex logic and better have an isolated change. BUG= 556171 , 445742 , 376823 , 249451 Review-Url: https://codereview.chromium.org/842193004 Cr-Commit-Position: refs/heads/master@{#406557} Commit : af5c2165bff01ba473fe28d31dd2a15d789ef08e Date : Wed Jul 20 15:09:08 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@406477 1284.91 3.45741 5 good chromium@406523 1272.55 6.59786 5 good chromium@406546 1299.51 0.911539 5 good chromium@406552 1290.22 4.07354 5 good chromium@406555 1286.37 4.65454 5 good chromium@406556 1294.48 4.5083 5 good chromium@406557 1104.52 3.71977 5 bad <-- chromium@406558 1101.42 3.853 5 bad chromium@406569 1114.12 2.84198 5 bad Bisect job ran on: winx64intel_perf_bisect Bug ID: 630459 Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.layout Test Metric: fixed-grid-lots-of-stretched-data/fixed-grid-lots-of-stretched-data Relative Change: 13.29% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1034 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006484957344895536 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5857333779890176 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jul 22 2016
=== Auto-CCing suspected CL author wkorman@chromium.org === Hi wkorman@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert "Add a hack to set shouldPaint to true for force-composited iframes." Author : wkorman Commit description: Reason: Exploring as possible cause of compositing/paint time performance regression. Original change description: This works around a FCB chicken-egg problem in which we are unable to properly start painting floating iframes once they stop being composited. https://codereview.chromium.org/2009353003 BUG= 610906 ,619710 Review-Url: https://codereview.chromium.org/2164813002 Cr-Commit-Position: refs/heads/master@{#406483} Commit : e080ea95241ea911fa5b97e27b18308ed4d8c1ae Date : Wed Jul 20 04:26:27 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@406477 1285.09 5.61508 8 good chromium@406480 1290.59 4.1253 5 good chromium@406482 1280.87 3.89086 5 good chromium@406483 1261.37 3.37105 5 bad <-- chromium@406490 1273.95 4.57722 5 bad chromium@406502 1274.04 4.35199 8 bad Bisect job ran on: winx64intel_perf_bisect Bug ID: 630459 Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.layout Test Metric: fixed-grid-lots-of-stretched-data/fixed-grid-lots-of-stretched-data Relative Change: 0.61% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1033 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006484974162882752 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5839966140104704 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rsch...@chromium.org
, Jul 21 2016