New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 630449 link

Starred by 2 users
Status: Fixed
Owner:
█ apaci...@chromium.org
no longer active
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Constrained Dialog] Enable autoresizing immediately if intended on OSX.

Project Member Reported by apaci...@chromium.org, Jul 21 2016 
This is a follow up to crbug/609863.

Constrained dialogs should always be 1) fixed size or 2) autoresizing during their lifetime, not switching between one or the other.

Currently, autoresizing is done at DocumentOnLoadCompletedInMainFrame() rather than in the constructor, which caused a race condition in CrOS. A fix landed for views, but not cocoa. This change is intended to be a clean up for consistency, and to avoid similar issues in the future.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52adac07902f533a2dcd860eee19ae47fb6c548c

commit 52adac07902f533a2dcd860eee19ae47fb6c548c
Author: apacible <apacible@chromium.org>
Date: Tue Jul 26 01:21:22 2016

[Constrained Web Dialogs] [Cocoa] Enable autoresizing immediately if intended.

Follow up to crbug/609863.

Constrained dialogs should always be 1) fixed size or 2) autoresizing during their lifetime, not switching between one or the other.

Previously, autoresizing was done at DocumentOnLoadCompletedInMainFrame() rather than in the constructor, which caused a race condition in CrOS. This change will keep implementations consistent across desktop platforms.

BUG= 630449 

Review-Url: https://codereview.chromium.org/2174573002
Cr-Commit-Position: refs/heads/master@{#407672}

[modify] https://crrev.com/52adac07902f533a2dcd860eee19ae47fb6c548c/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm

Comment 2 by apaci...@chromium.org, Jul 26 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment