New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 630443 link

Starred by 1 user
Status: WontFix
Owner:
█ laszio@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug

Blocking:
issue 537368



Sign in to add a comment

autotest-tests cannot be built by clang in thumb mode

Project Member Reported by laszio@chromium.org, Jul 21 2016 
It takes an infinite long time to build iTLB_benchmark_function.c:

$ clang -cc1 -triple thumbv7-linux-gnueabi -emit-obj -x c iTLB_benchmark_function.c

or

$ clang -target thumbv7-linux-gnueabi -c -o iTLB_benchmark_function.o -x c iTLB_benchmark_function.c -mthumb

A bug is also filed against LLVM:
https://llvm.org/bugs/show_bug.cgi?id=28649
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ea9ea5e265c3041f537fa24c62b94dfdde8fda18

commit ea9ea5e265c3041f537fa24c62b94dfdde8fda18
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Thu Aug 04 21:49:56 2016

autotest-tests: always use gcc to build autotest-tests.

clang's having trouble building some tests with -mthumb

BUG= chromium:630443 
TEST=cbuildbot falco-release daisy-release x86-alex-release

Change-Id: Ie294445401e69a0ad725ab0d4554377907507a8e
Reviewed-on: https://chromium-review.googlesource.com/362517
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/ea9ea5e265c3041f537fa24c62b94dfdde8fda18/chromeos/config/env/chromeos-base/autotest-tests

Comment 2 by llozano@chromium.org, Aug 19 2016

Blocking: 537368

Comment 3 by llozano@chromium.org, Aug 23 2016

Owner: laszio@chromium.org

Comment 4 by laszio@chromium.org, Aug 26 2016

Status: Assigned (was: Untriaged)
This was worked-around by building with gcc. Should we remove it from blocking 537368? Or just close it and create another one with more specific descriptions?

Comment 5 by yunlian@chromium.org, Sep 29 2016

Labels: llvm-runtime

Comment 6 by llozano@chromium.org, Oct 4 2016

Labels: -llvm-runtime llvm-buildtime
this is long buildtime issue. (although it is in in an autotest)

Comment 7 by nlewycky@google.com, Nov 22 2016 

Filed upstream at http://llvm.org/PR31124
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d95f9e5de8e1e95beaaead0bbaad3fbfdc84e15

commit 9d95f9e5de8e1e95beaaead0bbaad3fbfdc84e15
Author: rockot <rockot@chromium.org>
Date: Thu Mar 16 21:23:35 2017

Mojo EDK: Circulate MojoArmWatcher outputs to avoid starvation

Changes the implementation of MojoArmWatcher slightly so that
the set of ready handles is circulated across consecutive calls,
avoiding potential handle starvation by callers requesting a
small fixed number of outputs each time.

Also correctly iterates over only the ready handles in
WatcherDispatcher::Arm(), rather than less efficiently iterating
over all watched handles. (Ooops!)

BUG= 700171 
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2754083003
Cr-Commit-Position: refs/heads/master@{#457557}

[modify] https://crrev.com/9d95f9e5de8e1e95beaaead0bbaad3fbfdc84e15/mojo/edk/system/watcher_dispatcher.cc
[modify] https://crrev.com/9d95f9e5de8e1e95beaaead0bbaad3fbfdc84e15/mojo/edk/system/watcher_dispatcher.h
[modify] https://crrev.com/9d95f9e5de8e1e95beaaead0bbaad3fbfdc84e15/mojo/edk/system/watcher_unittest.cc
[modify] https://crrev.com/9d95f9e5de8e1e95beaaead0bbaad3fbfdc84e15/mojo/public/c/system/watcher.h

Comment 9 by laszio@chromium.org, Mar 17 2017

Status: WontFix (was: Assigned)
The test was removed in 25ebcf31b7540dc1ed6cd8c9c134a83044085acf.
►

Sign in to add a comment