New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630438 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Blimp testing dockerfile doesn't create user account that it tries to switch to

Project Member Reported by xyzzyz@chromium.org, Jul 21 2016

Issue description

See https://cs.chromium.org/chromium/src/blimp/engine/testing/Dockerfile?q=blimp+Dockerfile&sq=package:chromium&dr=C&l=1

blimp_user is referred to, but created neither in the base nor this dockerfile. This breaks testing docker image creation.
 

Comment 1 by xyzzyz@chromium.org, Jul 21 2016

Components: Mobile>Blimp
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6df4245122709b6a19e5f898d49a777b153c9bd7

commit 6df4245122709b6a19e5f898d49a777b153c9bd7
Author: jessicag <jessicag@chromium.org>
Date: Fri Jul 22 19:58:17 2016

Update ADD handling in Dockerfiles and test bundle creation.

Current Dockerfiles were written with a misunderstanding of how wildcards and directory sources interact with the ADD command. This was discovered in testing using the generated tarballs.

The change fixes an incorrect comment in the engine Dockerfile.

Additionally, create_bundle.py was updated to tar up the filesystem state from a context other than the build directory.

These changes mean that for the env_tests bundle, running the Dockerfile in the context of the tarball results in a system file structure such that /blimp/ contains the set of dpendencies for the testing binaries in the same directory structure as // (the chromium src directory).

This change does not remove the duplicate ./third_party/blimp_fonts (./fonts is used instead) for the engine environment.

BUG=616945,  608487 ,  630438 

Review-Url: https://codereview.chromium.org/2154873002
Cr-Commit-Position: refs/heads/master@{#407237}

[modify] https://crrev.com/6df4245122709b6a19e5f898d49a777b153c9bd7/blimp/BUILD.gn
[modify] https://crrev.com/6df4245122709b6a19e5f898d49a777b153c9bd7/blimp/engine/Dockerfile
[modify] https://crrev.com/6df4245122709b6a19e5f898d49a777b153c9bd7/blimp/engine/testing/Dockerfile
[modify] https://crrev.com/6df4245122709b6a19e5f898d49a777b153c9bd7/blimp/tools/create-bundle.py

Comment 3 by w...@chromium.org, Jul 22 2016

Status: Assigned (was: Untriaged)
Summary: Blimp testing dockerfile doesn't create user account that it tries to switch to (was: Blimp testing dockerfile doesn't create use it's trying to switch to)
Status: Fixed (was: Assigned)
Labels: Archive-Blimp

Sign in to add a comment