Blimp testing dockerfile doesn't create user account that it tries to switch to |
||||
Issue descriptionSee https://cs.chromium.org/chromium/src/blimp/engine/testing/Dockerfile?q=blimp+Dockerfile&sq=package:chromium&dr=C&l=1 blimp_user is referred to, but created neither in the base nor this dockerfile. This breaks testing docker image creation.
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6df4245122709b6a19e5f898d49a777b153c9bd7 commit 6df4245122709b6a19e5f898d49a777b153c9bd7 Author: jessicag <jessicag@chromium.org> Date: Fri Jul 22 19:58:17 2016 Update ADD handling in Dockerfiles and test bundle creation. Current Dockerfiles were written with a misunderstanding of how wildcards and directory sources interact with the ADD command. This was discovered in testing using the generated tarballs. The change fixes an incorrect comment in the engine Dockerfile. Additionally, create_bundle.py was updated to tar up the filesystem state from a context other than the build directory. These changes mean that for the env_tests bundle, running the Dockerfile in the context of the tarball results in a system file structure such that /blimp/ contains the set of dpendencies for the testing binaries in the same directory structure as // (the chromium src directory). This change does not remove the duplicate ./third_party/blimp_fonts (./fonts is used instead) for the engine environment. BUG=616945, 608487 , 630438 Review-Url: https://codereview.chromium.org/2154873002 Cr-Commit-Position: refs/heads/master@{#407237} [modify] https://crrev.com/6df4245122709b6a19e5f898d49a777b153c9bd7/blimp/BUILD.gn [modify] https://crrev.com/6df4245122709b6a19e5f898d49a777b153c9bd7/blimp/engine/Dockerfile [modify] https://crrev.com/6df4245122709b6a19e5f898d49a777b153c9bd7/blimp/engine/testing/Dockerfile [modify] https://crrev.com/6df4245122709b6a19e5f898d49a777b153c9bd7/blimp/tools/create-bundle.py
,
Jul 22 2016
,
Sep 30 2016
,
Dec 9 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by xyzzyz@chromium.org
, Jul 21 2016