Issue metadata
Sign in to add a comment
|
No easy way to dismiss info pane in Chromeplate |
||||||||||||||||||||||||
Issue descriptionApplication Version (from "Chrome Settings > About Chrome"): 51.0.2704.90 Android Build Number (from "Android Settings > About Phone/Tablet"): NME19C Device: Any Is Merge Tabs and Apps enabled: No Steps to reproduce: 1) Search for something in GSA 2) Tap on link 3) Tap on menu -> (i) in Chromeplate Observed behavior: A dismiss button, or some clear indication that tapping in the scrim dismisses Expected behavior: No easily discoverable way to dismiss Frequency: 100% Additional comments:
,
Jul 21 2016
Site settings is not really a CCT specific dialog, but a Chrome wide UI. I would say the dialog being dismissed when tapped inside the scrim is a platform standard, but sending over to rolfe to give an official verdict.
,
Jul 21 2016
Its somewhat standard, but I don't think documented as an accepted practice. In the Android Platform, dismissible dialogs generally have a button that dismisses them versus relying on a scrim tap.
,
Jul 22 2016
,
Jul 29 2016
Material menus (used in GSA) and bottom sheets (share sheet used in GSA and Chrome) can be dismissed three ways: 1) Tapping on the scrim 2) Tapping the system back button 3) Dragging (left on the menu, down on the share sheet) These look like the (i) page, and none have a close button, so I'm comfortable leaving it out. But Chrome's (i) page info can only be closed via No. 1 and 2 but not 3. +tsergeant who implemented page info to see about feasibility for No. 3. Can you comment on the bug and let us know? (Won't make you do it, just curious as I think you're most familiar with the code.)
,
Jul 29 2016
I think it would be feasible and a nice addition to have. I would expect it wouldn't be too much work for someone already familiar with Android UI (which prooooobably doesn't include me anymore, it's been a while since I've worked in this area).
,
Jul 29 2016
Cool thanks, will remove you to spare you future pings. +emilyschechter for triage. (As the sheet is in the security team's domain, hoping you can find an eng who could take on adding swipe to dismiss to the page info sheet.) +tedchoc as FYI in case the front-end team wants to take it on instead, or at least be aware of it.
,
Jul 29 2016
,
Aug 2 2016
+lshang, this might be a good introduction to Android UI CL
,
Aug 10 2016
,
Aug 10 2016
,
Aug 11 2016
@rolfe, do you have any more spec interaction details for lshang (i.e. how long of a swipe is needed to dismiss)? Would she send do you for review?
,
Aug 11 2016
I feel like there ought to be a repo for swipe specs but interestingly I don't think we have them, as swipe to dismiss happens so often on the system and our eng are so amazing. Curious if you can re-use existing behavior? Something the Touch to Search box (tap on an unlinked word, tap on the bottom bar that appears, and swipe to close that) or Share sheet (tap on overflow, click share, and swipe to close that) would be fine.
,
Aug 12 2016
Got it! Thanks! And on tablets the page info sheet is in the center of the screen, are we also add swiping to dismiss it? On smaller screens it's on the top, so I added swiping up to dismiss.
,
Aug 12 2016
Good questions. Dialogs don't have swiping in general so I'd leave it out there. But if it's sitting at the top on a smaller screen and looks like the phone UI then sure, swipe makes sense. Thanks!
,
Dec 4 2016
,
Jan 13 2017
As far as I understand, the OS "back" button is the standard way to dismiss, and the other ways are just extra |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by twelling...@chromium.org
, Jul 21 2016Status: Assigned (was: Untriaged)