New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630417 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----
Team-Security-UX



Sign in to add a comment

No easy way to dismiss info pane in Chromeplate

Project Member Reported by ijpedowitz@google.com, Jul 21 2016

Issue description

Application Version (from "Chrome Settings > About Chrome"): 51.0.2704.90
Android Build Number (from "Android Settings > About Phone/Tablet"): NME19C
Device: Any
Is Merge Tabs and Apps enabled: No

Steps to reproduce: 
1)  Search for something in GSA
2)  Tap on link
3)  Tap on menu -> (i) in Chromeplate

Observed behavior: A dismiss button, or some clear indication that tapping in the scrim dismisses

Expected behavior: No easily discoverable way to dismiss

Frequency: 
100%

Additional comments: 

 
Owner: yus...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by yus...@chromium.org, Jul 21 2016

Cc: yus...@chromium.org
Owner: rolfe@chromium.org
Site settings is not really a CCT specific dialog, but a Chrome wide UI. I would say the dialog being dismissed when tapped inside the scrim is a platform standard, but sending over to rolfe to give an official verdict.
Cc: dsandler@google.com
Its somewhat standard, but I don't think documented as an accepted practice.  In the Android Platform, dismissible dialogs generally have a button that dismisses them versus relying on a scrim tap.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 22 2016

Labels: Hotlist-Google

Comment 5 by rolfe@chromium.org, Jul 29 2016

Cc: tsergeant@chromium.org
Material menus (used in GSA) and bottom sheets (share sheet used in GSA and Chrome) can be dismissed three ways:
1) Tapping on the scrim
2) Tapping the system back button
3) Dragging (left on the menu, down on the share sheet)

These look like the (i) page, and none have a close button, so I'm comfortable leaving it out. But Chrome's (i) page info can only be closed via No. 1 and 2 but not 3.

+tsergeant who implemented page info to see about feasibility for No. 3. Can you comment on the bug and let us know? (Won't make you do it, just curious as I think you're most familiar with the code.)
I think it would be feasible and a nice addition to have. I would expect it wouldn't be too much work for someone already familiar with Android UI (which prooooobably doesn't include me anymore, it's been a while since I've worked in this area).

Comment 7 by rolfe@chromium.org, Jul 29 2016

Cc: rolfe@chromium.org tedc...@chromium.org
Owner: emilyschechter@chromium.org
Cool thanks, will remove you to spare you future pings.

+emilyschechter for triage. (As the sheet is in the security team's domain, hoping you can find an eng who could take on adding swipe to dismiss to the page info sheet.)

+tedchoc as FYI in case the front-end team wants to take it on instead, or at least be aware of it.

Comment 8 by rolfe@chromium.org, Jul 29 2016

Cc: -tsergeant@chromium.org
Cc: lshang@chromium.org
+lshang, this might be a good introduction to Android UI CL
Owner: lshang@chromium.org
Status: Started (was: Assigned)
Cc: -lshang@chromium.org emilyschechter@chromium.org
@rolfe, do you have any more spec interaction details for lshang (i.e. how long of a swipe is needed to dismiss)? Would she send do you for review?

Comment 13 by rolfe@chromium.org, Aug 11 2016

I feel like there ought to be a repo for swipe specs but interestingly I don't think we have them, as swipe to dismiss happens so often on the system and our eng are so amazing. Curious if you can re-use existing behavior? Something the Touch to Search box (tap on an unlinked word, tap on the bottom bar that appears, and swipe to close that) or Share sheet (tap on overflow, click share, and swipe to close that) would be fine.
Got it! Thanks!

And on tablets the page info sheet is in the center of the screen, are we also add swiping to dismiss it? On smaller screens it's on the top, so I added swiping up to dismiss.

Comment 15 by rolfe@chromium.org, Aug 12 2016

Good questions. Dialogs don't have swiping in general so I'd leave it out there. But if it's sitting at the top on a smaller screen and looks like the phone UI then sure, swipe makes sense. Thanks!
Owner: ----
Status: Available (was: Started)
Components: UI>Browser>Bubbles>PageInfo
Labels: -Restrict-View-Google
Status: WontFix (was: Available)
As far as I understand, the OS "back" button is the standard way to dismiss, and the other ways are just extra

Sign in to add a comment