New issue
Advanced search Search tips

Issue 630415 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Quick-add feature for custom omnibox search engines disappeared?

Reported by orsch...@gmail.com, Jul 21 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/51.0.2704.79 Chrome/51.0.2704.79 Safari/537.36

Steps to reproduce the problem:
Dear all, 

If I recall correctly, then Chromium used to have a context menu entry to add an input field as a custom search engine. 

What is the expected behavior?

What went wrong?
To do this, the following steps were necessary:

1. Right mouse click on an input search field on a website
2. Select "Add as custom search engine" (or similar)

Why has this feature being removed? Is there any way to bring it back?

This was always so useful to quickly add a new custom search engine (as opposed to having to go to the settings first). 

Thankfully,

~Robert

Did this work before? Yes 

Chrome version: 51.0.2704.79  Channel: stable
OS Version: Ubuntu 16.04
Flash Version: Shockwave Flash 11.2 r999
 
Cc: pkasting@chromium.org
Components: -UI UI>Browser>Omnibox
pkasting@, what do you know about this?
Owner: est...@chromium.org
Evan ripped this out because it wasn't actually useful.  My brain has already purged the details on why, so assigning this to him to explain.

Comment 3 by est...@chromium.org, Sep 26 2016

Status: WontFix (was: Unconfirmed)
the context menu item wasn't used very much and UX people were looking to trim down the contents of context menus. This entry was removed here (not by me) - https://crrev.com/5414139041953f2

I removed the js api addSearchProvider which is related but allowed sites to initiate instead of relying on the user to select an item from the context menu.

Most of the time we should automatically pick up the search engine over the course of normal usage. You do have to go to settings to e.g. modify the search term.
(FWIW that link 404s)

Comment 5 by est...@chromium.org, Sep 26 2016

hmm. Apparently crrev.com can't handle abbreviated commit hashes.

https://chromium.googlesource.com/chromium/src/+/5414139041953f2

Comment 6 by orsch...@gmail.com, Sep 27 2016

Dear all, 

I appreciate your comments!

The issue can be closed from my side unless you have something to add.

-Robert




Sign in to add a comment