App/tools menu error icon should use same vector icon from other platforms. |
|||
Issue descriptionOS: Mac OS What is the expected output? Global error menu items displayed on the app/tools menu use the circle-with-exclamation-point icon. What do you see instead? Global error menu items displayed on the app/tools menu use the rounded-rectangle-with-exclamation-point bitmap icon. See this CL for related changes on other platforms: https://codereview.chromium.org/2166853002/ See attachment for the expected icon:
,
Jul 21 2016
It should be a matter of changing the #define in GlobalError::MenuItemIcon() in chrome/browser/ui/global_error/global_error.cc. I just want to make sure that the new icon does actually show up in the menu on the Mac after doing so.
,
Aug 17 2016
Looking into this How should I simulate it?
,
Aug 24 2016
Somewhere there should be code that checks whether Chrome needs to show this error - can you put a temporary hack in that code that makes it always return this error level?
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09a373d94b03acf20ec60f35dd73de708e31d468 commit 09a373d94b03acf20ec60f35dd73de708e31d468 Author: spqchan <spqchan@chromium.org> Date: Fri Aug 26 20:15:13 2016 [Mac] Update the AppMenu Error icon Menu should use the new browser tools error icon. BUG= 630354 Review-Url: https://codereview.chromium.org/2280033003 Cr-Commit-Position: refs/heads/master@{#414791} [modify] https://crrev.com/09a373d94b03acf20ec60f35dd73de708e31d468/chrome/browser/ui/global_error/global_error.cc
,
Aug 26 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by kylixrd@chromium.org
, Jul 21 2016