New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 630342 link

Starred by 2 users
Status: Assigned
Owner:
█ servolk@chromium.org
Last visit > 30 days ago
Cc:
█ alokp@chromium.org
█ halliwell@chromium.org
dalecur...@chromium.org
wolenetz@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Make MSE source buffer memory limits configurable at runtime

Project Member Reported by alokp@chromium.org, Jul 21 2016 
Chromecast runs on a wide variety of hardware with different memory sizes where it is necessary to configure MSE buffer sizes.

We currently use a compile time option "use_low_memory_buffer=true" to select a smaller buffer on low-memory devices. But the compile-time option does not work where the same binary is used on multiple devices.

dalecurtis/wolenetz: Would it be OK to convert the compile-time option to a set of command-line flags? Any other ideas?

Comment 1 by alokp@chromium.org, Jul 21 2016

Cc: halliwell@chromium.org

Comment 2 by alokp@chromium.org, Jul 28 2016

Cc: -servolk@chromium.org alokp@chromium.org
Owner: servolk@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f93caffe7a63bdcb391e23f67c67ceb69718a0f

commit 2f93caffe7a63bdcb391e23f67c67ceb69718a0f
Author: servolk <servolk@chromium.org>
Date: Wed Aug 03 15:48:36 2016

Added virtual test suite with 1MB MSE buffers

This will run media-source*quota-exceeded tests in a virtual test suite
with MSE audio and video buffer sizes set to 1MB. Normally those tests
time out in Debug mode, since the default MSE audio buffer size is 12MB
and that takes to long to fill up in Debug build.

BUG=630342

Review-Url: https://codereview.chromium.org/2195933002
Cr-Commit-Position: refs/heads/master@{#409518}

[modify] https://crrev.com/2f93caffe7a63bdcb391e23f67c67ceb69718a0f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2f93caffe7a63bdcb391e23f67c67ceb69718a0f/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/d83ae56bf888bf9a46a9bb440ddd551da8635e98/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-appendbuffer-quota-exceeded.html
[delete] https://crrev.com/d83ae56bf888bf9a46a9bb440ddd551da8635e98/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-appendstream-quota-exceeded.html
[modify] https://crrev.com/2f93caffe7a63bdcb391e23f67c67ceb69718a0f/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-util.js
[add] https://crrev.com/2f93caffe7a63bdcb391e23f67c67ceb69718a0f/third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/README.txt
[add] https://crrev.com/2f93caffe7a63bdcb391e23f67c67ceb69718a0f/third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-1mb-buffers.html
[add] https://crrev.com/2f93caffe7a63bdcb391e23f67c67ceb69718a0f/third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-default-buffers.html
[add] https://crrev.com/2f93caffe7a63bdcb391e23f67c67ceb69718a0f/third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendstream-quota-exceeded-1mb-buffers.html
[add] https://crrev.com/2f93caffe7a63bdcb391e23f67c67ceb69718a0f/third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendstream-quota-exceeded-default-buffers.html
[add] https://crrev.com/2f93caffe7a63bdcb391e23f67c67ceb69718a0f/third_party/WebKit/LayoutTests/virtual/mse-1mb-buffers/http/tests/media/media-source/stream_memory_tests/README.txt

Comment 5 by yini...@chromium.org, Sep 11 2017 

sevolk@, as per c#3, should this bug be marked as Fixed? thanks
►

Sign in to add a comment