Once issue 486264 is fixed (Fix currently under review), I don't believe we'll need SingleRequestHostResolver any more. Its main purpose was to cancel requests when going out of scope, but that's just what unique_ptr<HostResolver::Request> now does.
Please assign to me. I'll remove it once fix is uploaded.
Unfortunately, issues can't be assigned to people without bug editing permissions. Your comment should be enough to consider this one owned by you.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/320d596edc998927c4578323e5c0797963370ae9 commit 320d596edc998927c4578323e5c0797963370ae9 Author: maksim.sisov <maksim.sisov@intel.com> Date: Mon Aug 15 18:02:51 2016 First step to remove SingleRequestHostResolver. This cl makes all the callers to use HostResolver instead of SingleRequestHostResolver. Next cl will remove the class completely. Second part - https://codereview.chromium.org/2212873002/ BUG= 630301 Review-Url: https://codereview.chromium.org/2214693002 Cr-Commit-Position: refs/heads/master@{#411981} [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/chrome/browser/net/predictor.cc [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/components/network_hints/browser/network_hints_message_filter.cc [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/content/browser/loader/resource_hints_impl.cc [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/content/browser/renderer_host/p2p/socket_dispatcher_host.cc [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/content/browser/renderer_host/pepper/pepper_lookup_request.h [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/dns/host_resolver_impl.cc [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/ftp/ftp_network_transaction.cc [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/ftp/ftp_network_transaction.h [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/http/http_auth_handler_negotiate.cc [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/http/http_auth_handler_negotiate.h [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/proxy/proxy_script_decider.cc [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/proxy/proxy_script_decider.h [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/quic/chromium/quic_stream_factory.cc [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/socket/socks_client_socket.cc [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/socket/socks_client_socket.h [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/socket/transport_client_socket_pool.cc [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/socket/transport_client_socket_pool.h [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/socket/websocket_transport_client_socket_pool.cc [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/socket/websocket_transport_client_socket_pool.h [modify] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/net/tools/quic/synchronous_host_resolver.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3b148c2f65ecff150684f8fb470b46d8fdc336c commit b3b148c2f65ecff150684f8fb470b46d8fdc336c Author: maksim.sisov <maksim.sisov@intel.com> Date: Tue Aug 16 05:43:23 2016 Remove SingleHostResolver completely. There is no need in SingleHostResolver after HostResolver::Request was implemented and HostResolver::Resolve() started to take unique_ptr instead of a raw pointer. First part - https://codereview.chromium.org/2214693002/ THIS CL WILL BE COMMITTED ONCE FIRST PART IS UPSTREAMED BUG= 630301 Review-Url: https://codereview.chromium.org/2212873002 Cr-Commit-Position: refs/heads/master@{#412172} [delete] https://crrev.com/75ce9c3e2c15f2df215184026162dc505df37e4b/net/dns/single_request_host_resolver.cc [delete] https://crrev.com/75ce9c3e2c15f2df215184026162dc505df37e4b/net/dns/single_request_host_resolver.h [delete] https://crrev.com/75ce9c3e2c15f2df215184026162dc505df37e4b/net/dns/single_request_host_resolver_unittest.cc [modify] https://crrev.com/b3b148c2f65ecff150684f8fb470b46d8fdc336c/net/net.gypi
Comment 1 by maksim.s...@intel.com
, Jul 26 2016