New issue
Advanced search Search tips

Issue 630294 link

Starred by 3 users
Status: Fixed
Owner:
taku...@chromium.org
Closed: Nov 2016
Cc:
sko...@chromium.org
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router WebUI] Custom controls ripple clipped and shifts.

Project Member Reported by apaci...@chromium.org, Jul 21 2016 
Version 54.0.2802.2 canary (64-bit)

1. Cast a YouTube video on MR.
2. Go to route details view.

If you make one of the control buttons at the bottom active, the material ripple is clipped at the bottom.

If you tab through the control buttons, the entire contents shift upwards to make space for the material ripple.

Observable on OSX but should be reproable on all desktop platforms.
Screen Shot 2016-07-21 at 07.51.47.png
81.0 KB View Download
Screen Shot 2016-07-21 at 07.52.09.png
77.0 KB View Download

Comment 1 by taku...@chromium.org, Jul 21 2016

Cc: sko...@chromium.org
Right now the height for the custom controls extension view is hard-coded, so if the custom controls are longer than that they get cropped. If we remove this hard-coding, we can let the custom controls decide their own height. Do we want to give them this freedom?

+skonig@

Comment 2 by taku...@chromium.org, Jul 26 2016

Labels: OS-Chrome OS-Linux OS-Windows
Stephen, what do you think regarding #1?

Comment 3 by sko...@chromium.org, Aug 23 2016 

I think it's fine to let the height scale based on the controls that are there, though we should be sure to not take up more than, say, 80% of the available height.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cf820b69968e571dc962e04ec91750e69843134

commit 5cf820b69968e571dc962e04ec91750e69843134
Author: takumif <takumif@chromium.org>
Date: Tue Nov 15 00:01:33 2016

[MR UI] Make custom controls / extensionview in the dialog taller by 6px

This change makes the custom controls taller, so that the custom controls for
YouTube, etc aren't clipped.

BUG= 630294 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2490003004
Cr-Commit-Position: refs/heads/master@{#431998}

[modify] https://crrev.com/5cf820b69968e571dc962e04ec91750e69843134/chrome/browser/resources/media_router/elements/route_details/route_details.css

Comment 5 by taku...@chromium.org, Nov 15 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment