New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630286 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Android Tests (dbg) bot flaky on net_unittests

Project Member Reported by timvolod...@chromium.org, Jul 21 2016

Issue description

I  179.684s run_tests_on_device(01ab756b0330210f)  Note: Google Test filter = OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/1
I  179.684s run_tests_on_device(01ab756b0330210f)  [==========] Running 1 test from 1 test case.
I  179.684s run_tests_on_device(01ab756b0330210f)  [----------] Global test environment set-up.
I  179.684s run_tests_on_device(01ab756b0330210f)  [----------] 1 test from OCSPVerify/HTTPSOCSPVerifyTest
I  179.684s run_tests_on_device(01ab756b0330210f)  [ RUN      ] OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/1
I  179.685s run_tests_on_device(01ab756b0330210f)  ../../net/url_request/url_request_unittest.cc:9491: Failure
I  179.685s run_tests_on_device(01ab756b0330210f)  Value of: ssl_info.ocsp_result.response_status
I  179.685s run_tests_on_device(01ab756b0330210f)    Actual: 1
I  179.685s run_tests_on_device(01ab756b0330210f)  Expected: test.response_status
I  179.685s run_tests_on_device(01ab756b0330210f)  Which is: 5
I  179.685s run_tests_on_device(01ab756b0330210f)  [  FAILED  ] OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/1, where GetParam() = 28-byte object <30-7E D3-79 38-7E D3-79 38-7E D3-79 00-00 00-00 05-00 00-00 00-00 00-00 02-00 00-00> (643 ms)
I  179.685s run_tests_on_device(01ab756b0330210f)  [----------] 1 test from OCSPVerify/HTTPSOCSPVerifyTest (643 ms total)
I  179.685s run_tests_on_device(01ab756b0330210f)  
I  179.685s run_tests_on_device(01ab756b0330210f)  [----------] Global test environment tear-down
I  179.685s run_tests_on_device(01ab756b0330210f)  [==========] 1 test from 1 test case ran. (646 ms total)
I  179.685s run_tests_on_device(01ab756b0330210f)  [  PASSED  ] 0 tests.
I  179.685s run_tests_on_device(01ab756b0330210f)  [  FAILED  ] 1 test, listed below:
I  179.685s run_tests_on_device(01ab756b0330210f)  
I  179.685s run_tests_on_device(01ab756b0330210f)   1 FAILED TEST
I  179.686s run_tests_on_device(01ab756b0330210f)  
I  179.686s run_tests_on_device(01ab756b0330210f)  OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/1FAILED
Cc: dadrian@google.com
there seems to be a recent patch by +cc:dadrian which could be related to this:
https://codereview.chromium.org/2100303002
Cc: rsleevi@chromium.org
I am going to disable it on android for now because multiple failures on two bots.

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb6944241978c8e1e8ff9e830acc8fed998828f1

commit cb6944241978c8e1e8ff9e830acc8fed998828f1
Author: timvolodine <timvolodine@chromium.org>
Date: Thu Jul 21 15:23:32 2016

Disable flaky HTTPSOCSPVerifyTest on Android.

This test has been added in https://codereview.chromium.org/2100303002
and appears to be flaky on the Android Tests (dbg) bot, see
 crbug.com/630286  for details.

BUG= 630286 
TBR=rsleevi@chromium.org,tedchoc@chromium.org,dadrian@google.com
NOTRY=true

Review-Url: https://codereview.chromium.org/2164303002
Cr-Commit-Position: refs/heads/master@{#406854}

[modify] https://crrev.com/cb6944241978c8e1e8ff9e830acc8fed998828f1/net/url_request/url_request_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4f98dd6b994a6510194bd2a85a1d3e6401f6ecd

commit b4f98dd6b994a6510194bd2a85a1d3e6401f6ecd
Author: dadrian <dadrian@google.com>
Date: Fri Jul 22 17:44:37 2016

Add more buffer time in HTTPSOCSPVerifyTests.

This leaves at least 1 day between the value of now() and thisUpdate/nextUpdate in OCSP responses generated by minica.py. This gives more wiggle room if there's a time differential between a test bot and a RemoteTestServer, and should help reduce HTTPSOCSPVerify test flakiness.

This also removes a reference to a non-existant variable in what should be an unreachable code path in minica.py.

BUG= 630286 

Review-Url: https://codereview.chromium.org/2170643004
Cr-Commit-Position: refs/heads/master@{#407192}

[modify] https://crrev.com/b4f98dd6b994a6510194bd2a85a1d3e6401f6ecd/net/tools/testserver/minica.py
[modify] https://crrev.com/b4f98dd6b994a6510194bd2a85a1d3e6401f6ecd/net/tools/testserver/testserver.py
[modify] https://crrev.com/b4f98dd6b994a6510194bd2a85a1d3e6401f6ecd/net/url_request/url_request_unittest.cc

Comment 8 by dadrian@google.com, Jul 25 2016

Status: Fixed (was: Untriaged)
I haven't seen any OCSP test failures since this CL landed.

Sign in to add a comment