New issue
Advanced search Search tips

Issue 630285 link

Starred by 2 users
Status: Fixed
Owner:
jkarlin@chromium.org
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Add scheduler metrics

Project Member Reported by jkarlin@chromium.org, Jul 21 2016 
We've run into situations in which the scheduler has locked up due to frozen operations. We can catch that sooner by adding a metric that samples when operations don't complete within say 10 seconds.

Further, we'd like to know how the sequential scheduler is performing, as
justification for parallelizing the scheduler in the future. So we should add metrics for that.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff

commit 8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff
Author: jkarlin <jkarlin@chromium.org>
Date: Tue Jul 26 19:30:13 2016

[CacheStorage] Add metrics to the scheduler

This CL adds UMA to keep track of operation stats such as how long the queue is
when adding an operation, how long each operation waits on the queue, how long
each operation takes, and whether operations freeze.

BUG= 630285 

Review-Url: https://codereview.chromium.org/2168123002
Cr-Commit-Position: refs/heads/master@{#407878}

[modify] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/content/browser/cache_storage/cache_storage_cache.cc
[add] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/content/browser/cache_storage/cache_storage_histogram_macros.h
[add] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/content/browser/cache_storage/cache_storage_operation.cc
[add] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/content/browser/cache_storage/cache_storage_operation.h
[add] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/content/browser/cache_storage/cache_storage_operation_unittest.cc
[modify] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/content/browser/cache_storage/cache_storage_scheduler.cc
[modify] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/content/browser/cache_storage/cache_storage_scheduler.h
[add] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/content/browser/cache_storage/cache_storage_scheduler_client.h
[modify] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/content/browser/cache_storage/cache_storage_scheduler_unittest.cc
[modify] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/content/content_browser.gypi
[modify] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/content/content_tests.gypi
[modify] https://crrev.com/8fdce7026ee44b2d26fa31bdd3f713d1fd9f92ff/tools/metrics/histograms/histograms.xml

Comment 2 by jkarlin@chromium.org, Jul 26 2016

Status: Fixed (was: Started)
►

Sign in to add a comment