New issue
Advanced search Search tips

Issue 630251 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename CancellationFlag to AtomicFlag

Project Member Reported by fdoray@chromium.org, Jul 21 2016

Issue description

CancellationFlag is really just a flag that can be set once from one thread and read from a number of other threads. It is already used to express other things than cancellation (e.g. in after_startup_task_utils.cc) and could be used at a few places in base/task_scheduler instead of WaitableEvent. To allow that, we should rename CancellationFlag to AtomicFlag.
 

Comment 1 by fdoray@chromium.org, Jul 27 2016

Status: Fixed (was: Started)
Done https://codereview.chromium.org/2163753004/
Status: Assigned (was: Fixed)
There are still instances of CancellationFlag in the codebase : https://cs.chromium.org/search/?q=%5CbCancellationFlag&sq=package:chromium&type=cs

Sign in to add a comment