Adding release block label, please undo if not the case.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87365b3f6c6293bac8a2513cef257d8e2cb0898a

commit 87365b3f6c6293bac8a2513cef257d8e2cb0898a
Author: foolip <foolip@chromium.org>
Date: Fri Jul 22 06:55:06 2016

Revert of Reland "Implement FullScreen using top layer." (patchset #13 id:260001 of https://codereview.chromium.org/2107233002/ )

Reason for revert:
Multiple regressions around the fullscreen transition becoming visibly
worse, as well as a suspected leak.

BUG= 628554 , 628605 , 628662 , 630191 

Original issue's description:
> Reland "Implement FullScreen using top layer."
>
> This reverts commit 2460a95281959d1b4dd941fed10998adf8dcb63c.
>
> Notable changes on top of previous attempt:
>
> full-screen-iframe-ua-style.html is changed to use overflow property
> instead, as position is no longer changed on ancestors.
>
> :root:-webkit-full-screen-ancestor { overflow: hidden !important; } is
> retained, as the previous attempt regressed on Vimeo ( crbug.com/543946 )
> and it's not clear yet how to handle this in the spec:
> https://github.com/whatwg/fullscreen/issues/19
>
> Make ::backdrop work for replaced content (video, iframe, etc.) by
> changing StyleResolver::createPseudoElementIfNeeded to allow creating
> the ::backdrop pseudo-element even if the parent doesn't support
> children. With this change, full-screen-stacking-context.html was
> simplified and full-screen-video-has-backdrop.html was
> simplified+renamed.
>
> The will-change override is dropped, as full-screen-will-change.html
> passes without it.
>
> BUG= 240576 ,  543946 
>
> Committed: https://crrev.com/d666f503ae854fac360cc70da1f5971a6724546a
> Cr-Commit-Position: refs/heads/master@{#405478}

TBR=dsinclair@chromium.org,esprehn@chromium.org,eae@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 240576 ,  543946 

Review-Url: https://codereview.chromium.org/2168373002
Cr-Commit-Position: refs/heads/master@{#407089}

[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen-expected.txt
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/enter-exit-full-screen-hover.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style-expected.txt
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-zIndex.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-render-inline-expected.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context-expected.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-zIndex-expected.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-iframe-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-iframe.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-object-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-object.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-video-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-video.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/overflow-root.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/overflow.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/resources/empty.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/resources/green.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/resources/white.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/video-webkit-transform-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/virtual/android/fullscreen/rendering/backdrop-video-expected.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/fullscreen.css
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/html.css
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Fullscreen.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/PseudoElement.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutBox.h
[add] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
[add] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutFullScreen.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutVideo.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutVideo.h
[add] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/api/LayoutFullScreenItem.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/api/LayoutItem.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/web/FullscreenController.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Just to update, still seeing this issue on Ubuntu 14.04 for build 54.0.2808.0. 

@ foolip: Request you to please take a look into it.

Thanks.!

I've tested this again in builds before and after the revert (comment #2) and after the revert, there is one particular bit of the bad transition that is gone. In the recording, after clicking the fullscreen button and the browsing window resizing, there are three frames where the video is seen in the lower left part of the screen before finally everything looks correct again.

This has been fixed by the revert, but the transition is still bad, but no worse than before.  Issue 396576  and  issue 407002  are parts of getting the timing exactly right so that there are no bad frames, but I'm closing this issue since it's a release blocker and in fact fixed.

I'm pretty sure about the above, but I could be mistaken, so if there is some aspect that's worse than in M53 even after the revert, please provide a recording that illustrates this.

Deleted: vlcsnap-2016-07-27-20h56m25s763.png 554 KB

	vlcsnap-2016-07-27-20h56m25s763.png 554 KB View Download