Regression: Spacing issue is observed in "Sign out" overlay in chrome://md-settings
Reported by
lpa...@etouch.net,
Jul 21 2016
|
||||
Issue descriptionChrome Version: Version: 54.0.2803.0 74ed884d4d42cb7152dc75fae33351e8e34220cd-refs/heads/master@{#406716} (32/64-bit) OS: Windows(7,8,8.1,10), Linux(14.04 LTS), Mac OS X(10.10.5, 10.11.4) Steps: 1. Launch chrome and sign in with valid credentials. 2. Navigate to chrome://md-settings and click on "Sign out". 3. Observe the "Cancel" and "Sign Out" buttons. Actual : No space is visible between "Cancel" and "Sign out" buttons. Expected: Space should be visible between "Cancel" and "Sign out" buttons. This is a regression issue seen from 'M-53'. Manual Regression range: Good Build: 53.0.2783.0 Bad Build : 53.0.2784.0 Can't perform Narrow Bisect as Chromium builds don't support signing in, hence providing suspect from Change Log: https://chromium.googlesource.com/chromium/src/+log/53.0.2783.0..53.0.2784.0?pretty=fuller&n=10000 Suspecting: r402981? from Change Log Kindly help to re-assign if your change is not the cause of this issue.
,
Jul 21 2016
The suspected revision above is not the culprit. Here is a narrower bisection range, https://chromium.googlesource.com/chromium/src/+log/6311f0fdc42799da33b9e28e6b784a1eda788aa0..3d05058f45ac24c192143f721572339af69f0acd. Culprit revision is r403001.
,
Jul 22 2016
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e6a36ee2555f7d11ac948d6af0e1f68b16ff81f commit 0e6a36ee2555f7d11ac948d6af0e1f68b16ff81f Author: tommycli <tommycli@chromium.org> Date: Fri Jul 22 19:39:47 2016 Settings People Revamp: Tweak Cancel button on Disconnect dialog. Adds a missing class to properly space the Cancel button on the Disconnect dialog in the People section. BUG= 630189 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2161363006 Cr-Commit-Position: refs/heads/master@{#407232} [modify] https://crrev.com/0e6a36ee2555f7d11ac948d6af0e1f68b16ff81f/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html [modify] https://crrev.com/0e6a36ee2555f7d11ac948d6af0e1f68b16ff81f/chrome/browser/resources/settings/people_page/people_page.html
,
Aug 17 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sheriffbot@chromium.org
, Jul 21 2016