Use Material Design for Desktop Window Picker new UI |
||||||||||||
Issue descriptionUse MD for the new window picker instead of native OS-style dialogues
,
Jul 21 2016
tapted@ - what would be a good bug number (or other means) to track the migration?
,
Jul 27 2016
varkha@: I have some questions about the material design of the UI foundation. During the implement the new UI for Desktop Capture Picker Window, we encountered some difficulties to make the picker window look identical as designed, which might be related to the foundation MD developement: 1. We used TabbedPane to implement the control switching between "screen", "window" and "chrome tab" sources. However, current TabbedPane does not expose any method for us to customize the appearance of the tab label button. Do you have plan of extending TabbedPane class to let caller customize the tab label button? Or do we have to use three buttons (and handle switch click ourselves)? 2. We use a checkbox on the window. According to the design, we hope that we could display the check mark as an audio image, but we can't if we stick to use Checkbox control. Do you plan to extend the Checkbox, so that the caller can set images for check/uncheck state, rather than use the standard check mark? Or do we have to use an image control and handle click event by ourselves? New Picker Design Link: https://docs.google.com/presentation/d/1xIgk_xNpa-4yBSR4DIcoDLfBFigu7SJwFWOdIzSC8r4/ The following picture is the current look. Focus on the tab label, and checkbox, which are still traditional looking instead of the fancy looking in the design doc.
,
Jul 28 2016
estade@ and pkasting@: Can you also take a look at #5, we have some questions on what MD will do. Thanks.
,
Jul 28 2016
Short answer is yes, use standard controls. We'll update all dialogs, controls, etc. to MD in such a way that your dialog gets them for "free".
,
Jul 28 2016
To elaborate on the above, we don't plan to roll out MD designs piecemeal but all at once. I'd say you could just close this bug, but you might just put it on hold till after all secondary UI (dialogs, bubbles, etc.) has been updated, then come back and make sure it looks as you expect.
,
Aug 5 2016
,
Dec 2 2016
,
May 31 2017
,
Jun 1 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 1 2018
,
Jun 4 2018
Is this launched on Mac? (if not.. is there any objection to using the toolkit-views version on Mac? And is someone who owns the Window Picker UI able to shepherd in such a change?)
,
Jun 4 2018
,
Jun 4 2018
,
Jun 4 2018
Maybe my change wasn't right. I assumed this was already done as a part of the larger material design effort, and this but created by us wasn't properly updated. If that's not true, please set the state accordingly.
,
Jun 5 2018
I think rob is looking, in Issue 726005.
,
Nov 6
Now only Mac remains. For other platforms, the appearance changed as the material design stuff landed. tapted@ or whoever knows the answer, I have a question: why did we not use the chrome UI component when making picker window on Mac, but we used the Mac API directly, which makes the appearance totally different from other platforms?
,
Nov 6
We didn't have the capability to launch toolkit-views UI on Mac when the picker was originally launched. We do now. Feel free to delete the Cocoa version :). |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by qiangchen@chromium.org
, Jul 21 2016Cc: shrike@chromium.org
Status: Available (was: Untriaged)