Regression: Forward slash is not gets entered for first time on chrome://history page.
Reported by
rk...@etouch.net,
Jul 21 2016
|
|||
Issue descriptionChrome Version: 54.0.2803.0 Revision 74ed884d4d42cb7152dc75fae33351e8e34220cd-refs/heads/master@{#406716}(32/64 bit) OS:Windows (7,8,10), Mac(10.10.5,10.11.4),Linux(14.04 LTS) What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://history page (2) Press 'Tab' focus till focus reaches to search field,then press forward slash arrow and observe. Forward slash is not gets entered for first time. Forward slash should gets entered every time. This is a regression issue, broken in 'M-54', below is bisect info: Good Build: 54.0.2800.0 Bad Build: 54.0.2802.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/244a1a1a56409dd6083908bdfefa73e8a2b62116..3fee5f7897422fb482c25780fada51b8869c6a8e?pretty=fuller&n=100 Suspecting: r406426 Note: It is working fine for other option(e.g Dot(.))
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be2ed6853f0834e6396188ad110ee1eecdef36f6 commit be2ed6853f0834e6396188ad110ee1eecdef36f6 Author: lshang <lshang@chromium.org> Date: Fri Jul 22 03:24:46 2016 MD History: Make the forward slash key to rely on focused only There are cases about the search field where: - it is showing and focused, which means user is inside the field and forward slash key should be regarded as input. - it is not showing and focused, in which case the forward slash key should be run shortcut command. - it is showing, but not focused, when there are some contents in the field and it loses focus, in this case forward slash key should be shortcut. - it is not showing, but focused, when user uses Tab to focus on the field, forward slash key should be input. Considering all these cases, the forward slash key shortcut should just rely on focused only. BUG= 630175 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2166263002 Cr-Commit-Position: refs/heads/master@{#407020} [modify] https://crrev.com/be2ed6853f0834e6396188ad110ee1eecdef36f6/chrome/browser/resources/md_history/app.js
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be2ed6853f0834e6396188ad110ee1eecdef36f6 commit be2ed6853f0834e6396188ad110ee1eecdef36f6 Author: lshang <lshang@chromium.org> Date: Fri Jul 22 03:24:46 2016 MD History: Make the forward slash key to rely on focused only There are cases about the search field where: - it is showing and focused, which means user is inside the field and forward slash key should be regarded as input. - it is not showing and focused, in which case the forward slash key should be run shortcut command. - it is showing, but not focused, when there are some contents in the field and it loses focus, in this case forward slash key should be shortcut. - it is not showing, but focused, when user uses Tab to focus on the field, forward slash key should be input. Considering all these cases, the forward slash key shortcut should just rely on focused only. BUG= 630175 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2166263002 Cr-Commit-Position: refs/heads/master@{#407020} [modify] https://crrev.com/be2ed6853f0834e6396188ad110ee1eecdef36f6/chrome/browser/resources/md_history/app.js
,
Jul 22 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ranjitkan@chromium.org
, Jul 21 2016