White vertical spaces in Desktop Capture Picker Window New UI "Entire Screen" View |
|||
Issue descriptionChrome Version : 54.0.2800.0 (Official Build) canary (64-bit) URLs (if applicable) : https://test.webrtc.org/manual/peer2peer/ What steps will reproduce the problem? (1) use new window picker UI (2) share screen (3) select "Entire Screen" tab What is the expected result? the preview title should be closer to the preview image, the preview image could be aligned top (tbd.) What happens instead? the preview image is centered, the title at the bottom of the area, resulting in large vertical white spaces Please provide any additional information below. Attach a screenshot if possible.
,
Jul 21 2016
One more update: I intended to change the cell size to be 450*300, which is closer to the screen width-height ratio. But failed, the image overflows for non-square size setting. (Looks weird, possibly a bug on apple side) So we have to stick to square cell size setting. And I did auto selection, and removed the redundant "Entire Screen" label.
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ddd74f352bda12bbad52aebb20fe9b6126eae1f commit 8ddd74f352bda12bbad52aebb20fe9b6126eae1f Author: qiangchen <qiangchen@chromium.org> Date: Mon Jul 25 16:34:35 2016 Mac Picker UI: Screen Auto Selection This CL improves usability of Desktop Capture Picker on Mac a little. 1. we auto select the first screen source, 2. we omit the label "Entire Screen" in the case there is only one screen, as this is redundant. BUG= 580116 , 630172 Review-Url: https://codereview.chromium.org/2168853003 Cr-Commit-Position: refs/heads/master@{#407490} [modify] https://crrev.com/8ddd74f352bda12bbad52aebb20fe9b6126eae1f/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm [modify] https://crrev.com/8ddd74f352bda12bbad52aebb20fe9b6126eae1f/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm [modify] https://crrev.com/8ddd74f352bda12bbad52aebb20fe9b6126eae1f/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.h [modify] https://crrev.com/8ddd74f352bda12bbad52aebb20fe9b6126eae1f/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.mm
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ddd74f352bda12bbad52aebb20fe9b6126eae1f commit 8ddd74f352bda12bbad52aebb20fe9b6126eae1f Author: qiangchen <qiangchen@chromium.org> Date: Mon Jul 25 16:34:35 2016 Mac Picker UI: Screen Auto Selection This CL improves usability of Desktop Capture Picker on Mac a little. 1. we auto select the first screen source, 2. we omit the label "Entire Screen" in the case there is only one screen, as this is redundant. BUG= 580116 , 630172 Review-Url: https://codereview.chromium.org/2168853003 Cr-Commit-Position: refs/heads/master@{#407490} [modify] https://crrev.com/8ddd74f352bda12bbad52aebb20fe9b6126eae1f/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm [modify] https://crrev.com/8ddd74f352bda12bbad52aebb20fe9b6126eae1f/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm [modify] https://crrev.com/8ddd74f352bda12bbad52aebb20fe9b6126eae1f/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.h [modify] https://crrev.com/8ddd74f352bda12bbad52aebb20fe9b6126eae1f/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.mm
,
Jul 26 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by qiangchen@chromium.org
, Jul 21 2016